From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16477 invoked by alias); 4 May 2012 13:45:16 -0000 Received: (qmail 16408 invoked by uid 22791); 4 May 2012 13:45:14 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 May 2012 13:44:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q44DiuSd018658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 May 2012 09:44:56 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q44Dis5Q006143; Fri, 4 May 2012 09:44:55 -0400 Message-ID: <4FA3DD56.8040303@redhat.com> Date: Fri, 04 May 2012 13:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120424 Thunderbird/12.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH/gdbserver] Remove current_inferior's save/restore when call get_thread_regcache. References: <1336128707-26498-1-git-send-email-yao@codesourcery.com> <4FA3CC30.70401@redhat.com> <4FA3D4B6.2040502@codesourcery.com> In-Reply-To: <4FA3D4B6.2040502@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00129.txt.bz2 On 05/04/2012 02:08 PM, Yao Qi wrote: > So any code needs inferior should be wrapped in the follow manner? Almost. The exception is code that takes an explicit thread argument (current_inferior is a thread pointer). So when you call: void foo (struct thread_info *thread) you don't have to care to swap the current_inferior global. `foo' will do it internally if necessary. -- Pedro Alves