From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25672 invoked by alias); 4 May 2012 02:11:21 -0000 Received: (qmail 25632 invoked by uid 22791); 4 May 2012 02:11:18 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 May 2012 02:11:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SQ7z4-0007Sc-S1 from Yao_Qi@mentor.com ; Thu, 03 May 2012 19:11:02 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 3 May 2012 19:11:01 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Thu, 3 May 2012 19:11:00 -0700 Message-ID: <4FA33AB1.7070304@codesourcery.com> Date: Fri, 04 May 2012 02:11:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Mark Kettenis , , Subject: Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method. References: <1336071802-13599-1-git-send-email-brobecker@adacore.com> <1336071802-13599-2-git-send-email-brobecker@adacore.com> <201205032144.q43Li5oQ009111@glazunov.sibelius.xs4all.nl> <20120503215752.GK15555@adacore.com> In-Reply-To: <20120503215752.GK15555@adacore.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00117.txt.bz2 On 05/04/2012 05:57 AM, Joel Brobecker wrote: >>> > > +/* Implement the push_dummy_code gdbarch method for mips targets. */ >> > >> > I notice people have been adding this style of comment in some other >> > newly contributed targets. Do people really feel that having these is >> > useful? If so, can we at least settle on a consitent style? > I think they are useful, because they allow us to tell people that > new functions should ALL be documented, even the obvious ones > that are used to implement a given hook. And since we do not > want to repeat the hook's documentation, this tells the reader > where to look. Yes, they are useful. Beyond Joel's description, it still quite useful when hook method's comment or parameter is changed, we don't have to change in every *-tdep.c files. > > I am happy to standardize on any format, as long as we all agree. +1. If hook is ABI or target variant specific, such as push_dummy_call in mips-tdep.c, BAR is the name of ABI or target variant, /* Implement the FOO gdbarch method for BAR. */ If hook is for the whole port, we can simply say this, /* Implement the FOO gdbarch method. */ -- Yao (齐尧)