From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12045 invoked by alias); 3 May 2012 06:51:57 -0000 Received: (qmail 12035 invoked by uid 22791); 3 May 2012 06:51:55 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from forward1.mail.yandex.net (HELO forward1.mail.yandex.net) (77.88.46.6) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 May 2012 06:51:38 +0000 Received: from smtp4.mail.yandex.net (smtp4.mail.yandex.net [77.88.46.104]) by forward1.mail.yandex.net (Yandex) with ESMTP id 24F141240933 for ; Thu, 3 May 2012 10:51:20 +0400 (MSK) Received: from smtp4.mail.yandex.net (localhost [127.0.0.1]) by smtp4.mail.yandex.net (Yandex) with ESMTP id 0A5D45C00F2 for ; Thu, 3 May 2012 10:51:20 +0400 (MSK) Received: from kts.bestnet.kharkov.ua (kts.bestnet.kharkov.ua [80.92.226.138]) by smtp4.mail.yandex.net (nwsmtp/Yandex) with ESMTP id pJBmdIGZ-pJBCSdS4; Thu, 3 May 2012 10:51:19 +0400 Message-ID: <4FA22AED.8090505@yandex.ru> Date: Thu, 03 May 2012 06:51:00 -0000 From: xgsa User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [patch] Use the string returned by pretty printer for MI varobjs instead of "{...}" References: <305151335125397@web28e.yandex.ru> In-Reply-To: <305151335125397@web28e.yandex.ru> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00056.txt.bz2 Ping! Please, review the patch. Anton. -------- Original message -------- > Hi, > > The documentation for -var-create says that "for a varobj whose type is some sort of aggregate (e.g., a struct), or for a dynamic varobj, the 'value' attribute will not be interesting". That's not true, as dynamic varobj could also have no children (so its value will be not "{...}" and will be interesting). However I think the string value of varobj that has pretty printer installed should always be returned via MI. It could contain such a useful information as container length or reference count for smart pointers. Moreover, it seems that this information cannot be accessed via MI in another way. This patch contains the proposed fix, documentation and test suite update. > > No regressions on linux32. > > > Thanks, > Anton