Re: [PATCH][SH] Signal handler unwinding for SH-Linux

Chung-Lin Tang
2012-05-07T13:19:18Z

On 2012/5/3 05:51 AM, Joel Brobecker wrote:
> Overall, this looks good to me. I do not know about SH specifically,
> so I will take your word on the specific location and layout of the
> sigcontext structure.
>
> Just a small minor comment: All new functions and globals should
> be documented. Usually, when we implement a "virtual method" (a
> function destined to be used as a pointer in one of our generic
> structures; Eg. sh_linux_sigreturn_init), we do not repeat description.
> We just say that this function implements such and such callback
> in struct bla bla for such and such situation. The actual documentation
> should already be provided at the same location the field itself
> is declared.
>
> For instance, one possible description of sh_linux_sigreturn_init
> is:
>
> /* Implement struct tramp_frame's "init" callback for signal
> trampolines on 32-bit SH. */

Hi Joel, thanks for reviewing. I've committed the patch with minor
additional comments like you suggested.

Chung-Lin