From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9743 invoked by alias); 27 Apr 2012 18:48:43 -0000 Received: (qmail 9607 invoked by uid 22791); 27 Apr 2012 18:48:40 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from forward15.mail.yandex.net (HELO forward15.mail.yandex.net) (95.108.130.119) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 18:48:24 +0000 Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68]) by forward15.mail.yandex.net (Yandex) with ESMTP id 0A8819E2215 for ; Fri, 27 Apr 2012 22:48:22 +0400 (MSK) Received: from smtp13.mail.yandex.net (localhost [127.0.0.1]) by smtp13.mail.yandex.net (Yandex) with ESMTP id ECB49E4050B for ; Fri, 27 Apr 2012 22:48:21 +0400 (MSK) Received: from kts.bestnet.kharkov.ua (kts.bestnet.kharkov.ua [80.92.226.138]) by smtp13.mail.yandex.net (nwsmtp/Yandex) with ESMTP id mJGqRWqe-mLGG0h6c; Fri, 27 Apr 2012 22:48:21 +0400 Message-ID: <4F9AE9FF.6090300@yandex.ru> Date: Fri, 27 Apr 2012 18:51:00 -0000 From: xgsa User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [patch] Use the string returned by pretty printer for MI varobjs instead of "{...}" References: <305151335125397@web28e.yandex.ru> In-Reply-To: <305151335125397@web28e.yandex.ru> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01027.txt.bz2 Ping, could anybody review the patch? Thanks, Anton -------- Original message -------- > Hi, > > The documentation for -var-create says that "for a varobj whose type is some sort of aggregate (e.g., a struct), or for a dynamic varobj, the 'value' attribute will not be interesting". That's not true, as dynamic varobj could also have no children (so its value will be not "{...}" and will be interesting). However I think the string value of varobj that has pretty printer installed should always be returned via MI. It could contain such a useful information as container length or reference count for smart pointers. Moreover, it seems that this information cannot be accessed via MI in another way. This patch contains the proposed fix, documentation and test suite update. > > No regressions on linux32. > > > Thanks, > Anton