From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19349 invoked by alias); 26 Apr 2012 19:33:30 -0000 Received: (qmail 19337 invoked by uid 22791); 26 Apr 2012 19:33:29 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 19:33:14 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QJXCQL007745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 15:33:12 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QJXAt5016337; Thu, 26 Apr 2012 15:33:11 -0400 Message-ID: <4F99A2F6.8050403@redhat.com> Date: Thu, 26 Apr 2012 19:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Will Deacon CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> In-Reply-To: <1335463380-7288-1-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00961.txt.bz2 On 04/26/2012 07:03 PM, Will Deacon wrote: > 2012-04-26 Will Deacon > > * linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and > PT_DATA_ADDR definitions from asm/ptrace.h. This needs tweaking to conform to the GNU Coding Standards. Write as: * linux-low.c [__UCLIBC__ && !(__UCLIBC_HAS_MMU__ || __ARCH_HAS_MMU__)]: Include asm/ptrace.h. (PT_TEXT_ADDR, PT_DATA_ADDR, PT_TEXT_END_ADDR): Define only if not already defined. Okay with this, and the formatting issues pointed out by Mike fixed. Though I do think that we don't need to worry about only a subset being defined... Thanks guys. -- Pedro Alves