From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32180 invoked by alias); 26 Apr 2012 18:48:36 -0000 Received: (qmail 32172 invoked by uid 22791); 26 Apr 2012 18:48:35 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:48:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QImEhT029703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 14:48:14 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QImDji011923; Thu, 26 Apr 2012 14:48:13 -0400 Message-ID: <4F99986D.3090305@redhat.com> Date: Thu, 26 Apr 2012 18:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Will Deacon CC: Mike Frysinger , "gdb-patches@sourceware.org" Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <201204261412.33446.vapier@gentoo.org> <4F9990A3.6030905@redhat.com> <201204261427.46580.vapier@gentoo.org> <4F999469.10406@redhat.com> <20120426183335.GD20186@mudshark.cambridge.arm.com> In-Reply-To: <20120426183335.GD20186@mudshark.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00952.txt.bz2 On 04/26/2012 07:33 PM, Will Deacon wrote: > On Thu, Apr 26, 2012 at 07:31:05PM +0100, Pedro Alves wrote: >> On 04/26/2012 07:27 PM, Mike Frysinger wrote: >> >>> On Thursday 26 April 2012 14:14:59 Pedro Alves wrote: >>>> On 04/26/2012 07:12 PM, Mike Frysinger wrote: >>>>> On Thursday 26 April 2012 14:03:00 Will Deacon wrote: >>>>>>> +/* PTRACE_TEXT_ADDR and friends. */ >>>>>>> +#include >>>>> >>>>> check for asm/ptrace.h in configure.ac and then just depend on >>>>> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is >>>>> realistically the only C library being used with no-mmu Linux systems. >>>> >>>> Was there a time Linux didn't have this header? When we include it GDB, we >>>> include it unconditionally (though we don't include it in all ports), and >>>> in current mainline, it seems that all 27 ports under arch/ have it. >>> >>> it's not so much a matter of whether it's provided, but whether it can be >>> safely included. ia64 has a history of being a pita to include their ptrace >>> headers, but maybe that doesn't matter to gdbserver. >> >> >> There are ia64 boxes on the gcc compile farm. Let me give that a try. > > The ordering of includes probably also comes into play here. I guess we > want: > > > > "linux-ptrace.h" > > and then we hope they all play nicely together with their own namespaces. > Bah, they don't... Before sys/ptrace.h. gcc -c -g3 -O0 -I. -I../../../src/gdb/gdbserver -I../../../src/gdb/gdbserver/../common -I../../../src/gdb/gdbserver/../regformats -I../../../src/gdb/gdbserver/../../include -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Werror ../../../src/gdb/gdbserver/linux-low.c In file included from /usr/include/asm/ptrace.h:58, from ../../../src/gdb/gdbserver/linux-low.c:27: /usr/include/asm/fpu.h:57: error: redefinition of ‘struct ia64_fpreg’ In file included from ../../../src/gdb/gdbserver/linux-low.c:28: /usr/include/sys/ptrace.h:75: error: expected identifier before numeric constant /usr/include/sys/ptrace.h:117: error: redefinition of ‘struct pt_all_user_regs’ ../../../src/gdb/gdbserver/linux-low.c: In function ‘linux_attach_lwp_1’: ../../../src/gdb/gdbserver/linux-low.c:669: error: ‘PTRACE_ATTACH’ undeclared (first use in this function) ../../../src/gdb/gdbserver/linux-low.c:669: error: (Each undeclared identifier is reported only once ../../../src/gdb/gdbserver/linux-low.c:669: error: for each function it appears in.) ../../../src/gdb/gdbserver/linux-low.c: In function ‘linux_detach_one_lwp’: ../../../src/gdb/gdbserver/linux-low.c:1139: error: ‘PTRACE_DETACH’ undeclared (first use in this function) make: *** [linux-low.o] Error 1 After sys/ptrace.h. gcc -c -g3 -O0 -I. -I../../../src/gdb/gdbserver -I../../../src/gdb/gdbserver/../common -I../../../src/gdb/gdbserver/../regformats -I../../../src/gdb/gdbserver/../../include -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Werror ../../../src/gdb/gdbserver/linux-low.c In file included from /usr/include/asm/ptrace.h:58, from ../../../src/gdb/gdbserver/linux-low.c:28: /usr/include/asm/fpu.h:57: error: redefinition of ‘struct ia64_fpreg’ In file included from ../../../src/gdb/gdbserver/linux-low.c:28: /usr/include/asm/ptrace.h:208: error: redefinition of ‘struct pt_all_user_regs’ make: *** [linux-low.o] Error 1 -- Pedro Alves