Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h

Will Deacon
2012-04-26T18:34:02Z

On Thu, Apr 26, 2012 at 07:31:05PM +0100, Pedro Alves wrote:
> On 04/26/2012 07:27 PM, Mike Frysinger wrote:
>
> > On Thursday 26 April 2012 14:14:59 Pedro Alves wrote:
> >> On 04/26/2012 07:12 PM, Mike Frysinger wrote:
> >>> On Thursday 26 April 2012 14:03:00 Will Deacon wrote:
> >>>>> +/* PTRACE_TEXT_ADDR and friends. */
> >>>>> +#include <asm/ptrace.h>
> >>>
> >>> check for asm/ptrace.h in configure.ac and then just depend on
> >>> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is
> >>> realistically the only C library being used with no-mmu Linux systems.
> >>
> >> Was there a time Linux didn't have this header? When we include it GDB, we
> >> include it unconditionally (though we don't include it in all ports), and
> >> in current mainline, it seems that all 27 ports under arch/ have it.
> >
> > it's not so much a matter of whether it's provided, but whether it can be
> > safely included. ia64 has a history of being a pita to include their ptrace
> > headers, but maybe that doesn't matter to gdbserver.
>
>
> There are ia64 boxes on the gcc compile farm. Let me give that a try.

The ordering of includes probably also comes into play here. I guess we
want:

<asm/ptrace.h>
<sys/ptrace.h>
"linux-ptrace.h"

and then we hope they all play nicely together with their own namespaces.

Will