Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h

Will Deacon
2012-04-26T18:36:55Z

Hi Mike,

On Thu, Apr 26, 2012 at 07:12:31PM +0100, Mike Frysinger wrote:
> On Thursday 26 April 2012 14:03:00 Will Deacon wrote:
> > +/* PTRACE_TEXT_ADDR and friends. */
> > +#include <asm/ptrace.h>
>
> check for asm/ptrace.h in configure.ac and then just depend on
> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is realistically
> the only C library being used with no-mmu Linux systems.

I'll see how Pedro gets on with the unconditional include first.

> > #if defined(__UCLIBC__) && defined(HAS_NOMMU)
> > +#if !(defined(PT_TEXT_ADDR) || \
> > + defined(PT_DATA_ADDR) || \
> > + defined(PT_TEXT_END_ADDR))
>
> i think the GNU way is to have the || at the start of line rather than end,
> and a space before the "(" (although i can see that rule isn't completely
> honored in this file).

Thanks, will fix.

Will