From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90404-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15075 invoked by alias); 26 Apr 2012 18:09:46 -0000
Received: (qmail 15064 invoked by uid 22791); 26 Apr 2012 18:09:44 -0000
X-SWARE-Spam-Status: No, hits=-7.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:09:32 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QI9Sc1001398	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 26 Apr 2012 14:09:28 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3QI9Q7v022027;	Thu, 26 Apr 2012 14:09:27 -0400
Message-ID: <4F998F56.6070201@redhat.com>
Date: Thu, 26 Apr 2012 18:11:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Will Deacon <will.deacon@arm.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
References: <1335463380-7288-1-git-send-email-will.deacon@arm.com>
In-Reply-To: <1335463380-7288-1-git-send-email-will.deacon@arm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00939.txt.bz2

On 04/26/2012 07:03 PM, Will Deacon wrote:

>  #ifdef __UCLIBC__
>  #if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
> +/* PTRACE_TEXT_ADDR and friends.  */
> +#include <asm/ptrace.h>
>  #define HAS_NOMMU
>  #endif
>  #endif


Is there a reason you're still not putting this unconditionally at
the top, next to sys/ptrace.h, etc.?

-- 
Pedro Alves