From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30149 invoked by alias); 26 Apr 2012 18:26:59 -0000 Received: (qmail 30141 invoked by uid 22791); 26 Apr 2012 18:26:58 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:26:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QIQE2o021217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 14:26:40 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QH8IfO007957; Thu, 26 Apr 2012 13:08:18 -0400 Message-ID: <4F998102.4010209@redhat.com> Date: Thu, 26 Apr 2012 18:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Will Deacon CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h References: <1335455675-1453-1-git-send-email-will.deacon@arm.com> <4F99718A.2090703@redhat.com> <20120426160926.GA20186@mudshark.cambridge.arm.com> In-Reply-To: <20120426160926.GA20186@mudshark.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00944.txt.bz2 On 04/26/2012 05:09 PM, Will Deacon wrote: > On Thu, Apr 26, 2012 at 05:02:18PM +0100, Pedro Alves wrote: >> On 04/26/2012 04:54 PM, Will Deacon wrote: >>> >>> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c >>> index 35d7e69..93d1f36 100644 >>> --- a/gdb/gdbserver/linux-low.c >>> +++ b/gdb/gdbserver/linux-low.c >>> @@ -4772,6 +4772,8 @@ linux_stopped_data_address (void) >>> #define PT_TEXT_ADDR (0x10000*4) >>> #define PT_DATA_ADDR (0x10004*4) >>> #define PT_TEXT_END_ADDR (0x10008*4) >>> +#else >>> +#include >>> #endif >> >> >> I'd much rather we include asm/ptrace.h unconditionally at the top, and wrap the >> existing #defines in (a single) #ifndef PT_TEXT_ADDR. That'll allow easily trimming >> that section in a few years time, if/when we bump the minimum kernel version >> required past a version that is known to define those for those archs. If that breaks >> one of those archs, we'll hear about it soon enough, don't sweat about it. :-) > > Right-o. I did actually try that initially but it gets fairly ugly if you > want to deal with the case where only a subset of the #defines exist in the > header. If breaking these archs isn't a big concern up-front, then I'm happy > just to test PT_TEXT_ADDR for each of them and be done with it. Plus, that > should take care of the sane configurations. Yes, let's try that first please. Looking at Linux's git, I see that sh's definition of those symbols came in be6514c6 (all three of them), arm in 68b7f715 (ditto), bfin in 1394f032 (ditto), microblaze in c47f10ba (ditto). I can't find any reference to those symbols under arch/m68k or arch/c6x (maybe those are still out of tree? though that surprises me, so it may be I should be looking for something else), but still, I don't think we need to worry about only a subset being defined. -- Pedro Alves