From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16809 invoked by alias); 26 Apr 2012 16:02:38 -0000 Received: (qmail 16792 invoked by uid 22791); 26 Apr 2012 16:02:36 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 16:02:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QG2JMe008526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 12:02:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QG2ICa018755; Thu, 26 Apr 2012 12:02:19 -0400 Message-ID: <4F99718A.2090703@redhat.com> Date: Thu, 26 Apr 2012 16:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Will Deacon CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h References: <1335455675-1453-1-git-send-email-will.deacon@arm.com> In-Reply-To: <1335455675-1453-1-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00927.txt.bz2 On 04/26/2012 04:54 PM, Will Deacon wrote: > When debugging a uclinux target, it is necessary to retrieve the text > and data offsets of the running program in order for symbol resolution > to work correctly. > > This patch pulls in definitions for PT_{TEXT,DATA,TEXT_END}_ADDR from > the kernel's exported ptrace header, which can be issued as `magic' > addresses to the PTRACE_PEEKUSER request in order to retrieve the child > offsets. > --- > > 2012-04-17 Will Deacon > > * linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and > PT_DATA_ADDR definitions from asm/ptrace.h. > > gdb/gdbserver/linux-low.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c > index 35d7e69..93d1f36 100644 > --- a/gdb/gdbserver/linux-low.c > +++ b/gdb/gdbserver/linux-low.c > @@ -4772,6 +4772,8 @@ linux_stopped_data_address (void) > #define PT_TEXT_ADDR (0x10000*4) > #define PT_DATA_ADDR (0x10004*4) > #define PT_TEXT_END_ADDR (0x10008*4) > +#else > +#include > #endif I'd much rather we include asm/ptrace.h unconditionally at the top, and wrap the existing #defines in (a single) #ifndef PT_TEXT_ADDR. That'll allow easily trimming that section in a few years time, if/when we bump the minimum kernel version required past a version that is known to define those for those archs. If that breaks one of those archs, we'll hear about it soon enough, don't sweat about it. :-) -- Pedro Alves