From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6321 invoked by alias); 24 Apr 2012 18:02:51 -0000 Received: (qmail 6293 invoked by uid 22791); 24 Apr 2012 18:02:48 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 18:02:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OI2adb015595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 14:02:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3OI2ZSS027934; Tue, 24 Apr 2012 14:02:35 -0400 Message-ID: <4F96EABA.7090806@redhat.com> Date: Tue, 24 Apr 2012 18:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Sergio Durigan Junior CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Refactor observer.sh to cleanup unused vars References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00817.txt.bz2 On 04/24/2012 06:53 PM, Sergio Durigan Junior wrote: > Hi, > > As requested by Pedro, this is the change to `observer.sh' made to > cleanup the unused variable `args'. Thanks. > I noticed that the variable is only > used as an argument for calling `notify', and in some cases `notify' > doesn't take arguments, thus leading to an unused `args' hanging > around. This patch removes it by conditionally declaring the variable. > > OK to apply? Okay. > 2012-04-24 Sergio Durigan Junior > > * observer.sh: Conditionally declare `args', thus cleaning up > unused cases. -- Pedro Alves