From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31869 invoked by alias); 24 Apr 2012 17:49:37 -0000 Received: (qmail 31856 invoked by uid 22791); 24 Apr 2012 17:49:35 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 17:49:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHnI48004074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 13:49:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHnGeA009671; Tue, 24 Apr 2012 13:49:17 -0400 Message-ID: <4F96E79C.6030208@redhat.com> Date: Tue, 24 Apr 2012 17:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag) References: <4F968B4D.3050209@redhat.com> <87wr55do66.fsf@fleche.redhat.com> In-Reply-To: <87wr55do66.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00812.txt.bz2 On 04/24/2012 06:39 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> There's no need to commit all this in one go. Once you split, > Pedro> some of the resulting patches will be dead obvious, and will end up > Pedro> reviewed (if even necessary) and checked in quickly, and thus you end up > Pedro> making progress faster that way. > > It seems to me that a variable that is declared but not initialized and > not used is always going to be obviously dead. I'd be comfortable with > pre-approving all such removals; leaving review for the patches to the > generators and initialized variables. Yes, that seems like a good cut. -- Pedro Alves