From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90262-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6456 invoked by alias); 24 Apr 2012 16:33:56 -0000
Received: (qmail 6421 invoked by uid 22791); 24 Apr 2012 16:33:54 -0000
X-SWARE-Spam-Status: No, hits=-7.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 16:33:39 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OGXP7E015524	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 24 Apr 2012 12:33:25 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OGXNMH007956;	Tue, 24 Apr 2012 12:33:24 -0400
Message-ID: <4F96D5D3.1040003@redhat.com>
Date: Tue, 24 Apr 2012 16:38:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jeff Kenton <jkenton@tilera.com>
CC: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb)
References: <4F906647.8090303@tilera.com> <20120420124306.GJ2852@adacore.com> <4F95B46D.1070101@tilera.com>
In-Reply-To: <4F95B46D.1070101@tilera.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00797.txt.bz2

On 04/23/2012 08:58 PM, Jeff Kenton wrote:

> +                  /* This is a special case. We're fixing up the stack frame.  */
> +                  unsigned long long hopefully_sp =
> +                    (unsigned)reverse_frame[operands[1]].value;
> +                  short op2_as_short = (short)operands[2];
> +                  signed char op2_as_char = (signed char)operands[2];
> +


We avoid long long as it's not C90.  I didn't look closely, but is this
code all host/endian independent?

-- 
Pedro Alves