From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12340 invoked by alias); 20 Apr 2012 14:16:31 -0000 Received: (qmail 12327 invoked by uid 22791); 20 Apr 2012 14:16:29 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Apr 2012 14:16:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3KEG0UN016849 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Apr 2012 10:16:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3KEFwPY006346; Fri, 20 Apr 2012 10:15:59 -0400 Message-ID: <4F916F9E.6040209@redhat.com> Date: Fri, 20 Apr 2012 14:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: gdb-patches@sourceware.org, Richard Sandiford Subject: Re: [RFA] MIPS/GDB: Fix the handling of MIPS16 thunks References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00682.txt.bz2 Hi Maciej, Some minor issues I noticed while browsing the patch. On 04/10/2012 11:20 PM, Maciej W. Rozycki wrote: > + /* macro/2005-03-31: This hack skips over MIPS16 call thunks as Eh, that long? Might want to update that date to the check in date, or drop it. Otherwise it's just useless, IMO. > + > +static int mips_is_stub_suffix (const char *suffix, int zero) Function name at column 0. > + > +static int mips_is_stub_mode (const char *mode) > +{ Ditto. > Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.arch/mips16-thunks-sin.c > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.arch/mips16-thunks-sin.c 2012-04-05 21:42:24.995424172 +0100 > @@ -0,0 +1,38 @@ > +#include > + I've noticed the tests miss copyright headers. > +gdb_breakpoint inmain > +gdb_run_cmd > +gdb_expect 30 { > + -re "Breakpoint 1.*inmain .*$gdb_prompt $" { > + send_gdb "finish\n" > + gdb_expect { > + -re "Value returned is \\\$\[0-9\]+ = 0\[^0-9\].*$gdb_prompt $" { Can we use gdb_test_multiple (catching internal errors etc., and dropping the default cases) ? (other instances) > +# Single-step through the function that is at the head of function list > +# FUNCS until a different function (frame) is reached. Before each step > +# check the backtrace against FUNCS. ID is used for reporting, to tell > +# apart different calls to this procedure for the same function. If > +# successful, then return the name of the function we have stopped in. > +proc step_through { id funcs } { Not sure it'd be useful here, but note the new with_test_prefix routine, which we now use as a convenient way to make sure there are no duplicate messages in gdb.sum (, as in ). -- Pedro Alves