From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15145 invoked by alias); 19 Apr 2012 04:14:03 -0000 Received: (qmail 15086 invoked by uid 22791); 19 Apr 2012 04:13:58 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Apr 2012 04:13:17 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SKik7-00028i-M9 from Yao_Qi@mentor.com ; Wed, 18 Apr 2012 21:13:15 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 18 Apr 2012 21:12:32 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 18 Apr 2012 21:13:14 -0700 Message-ID: <4F8F90F1.4020701@codesourcery.com> Date: Thu, 19 Apr 2012 04:35:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 5/5] move server.h to gdbthread.h. References: <1331909994-9473-1-git-send-email-yao@codesourcery.com> <1331909994-9473-6-git-send-email-yao@codesourcery.com> <87wr5jwn2r.fsf@fleche.redhat.com> In-Reply-To: <87wr5jwn2r.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00614.txt.bz2 On 04/14/2012 01:36 AM, Tom Tromey wrote: >>>>>> "Yao" == Yao Qi writes: > > Yao> diff --git a/gdb/gdbserver/gdbthread.h b/gdb/gdbserver/gdbthread.h > Yao> new file mode 100644 > Yao> index 0000000..d42b6fd > Yao> --- /dev/null > Yao> +++ b/gdb/gdbserver/gdbthread.h > Yao> @@ -0,0 +1,53 @@ > Yao> +#ifndef GDB_THREAD_H > Yao> +#define GDB_THREAD_H > Yao> + > > This one needs a copyright header too. > This version adds copyright header in gdbserver/gdbthread.h, and make this patch as a standalone one, not depends on patch 3/5 and 4/5 anymore. I'll commit next week if no objections. -- gdb/gdbserver: 2012-04-19 Yao Qi * server.h: Move some code to ... * gdbthread.h: ... here. New. * Makefile.in (inferiors.o, regcache.o): Depends on gdbthread.h (remote-utils.o, server.o, target.o tracepoint.o): Likewise. (nto-low.o, win32-low.o): Likewise. * inferiors.c, linux-low.h, nto-low.c: Include gdbthread.h. * regcache.c, remote-utils.c, server.c: Likewise. * target.c, tracepoint.c, win32-low.c: Likewise. --- gdb/gdbserver/Makefile.in | 19 ++++++----- gdb/gdbserver/gdbthread.h | 71 ++++++++++++++++++++++++++++++++++++++++++ gdb/gdbserver/inferiors.c | 1 + gdb/gdbserver/linux-low.h | 1 + gdb/gdbserver/nto-low.c | 1 + gdb/gdbserver/regcache.c | 1 + gdb/gdbserver/remote-utils.c | 1 + gdb/gdbserver/server.c | 1 + gdb/gdbserver/server.h | 46 +-------------------------- gdb/gdbserver/tracepoint.c | 1 + gdb/gdbserver/win32-low.c | 1 + 11 files changed, 91 insertions(+), 53 deletions(-) create mode 100644 gdb/gdbserver/gdbthread.h diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index 7d29f85..39976b9 100644 --- a/gdb/gdbserver/Makefile.in +++ b/gdb/gdbserver/Makefile.in @@ -398,7 +398,8 @@ server_h = $(srcdir)/server.h $(regcache_h) config.h $(srcdir)/target.h \ $(ptid_h) \ $(signals_h) -linux_low_h = $(srcdir)/linux-low.h +gdbthread_h = $(srcdir)/gdbthread.h $(target_h) $(srcdir)/server.h +linux_low_h = $(srcdir)/linux-low.h $(gdbthread_h) linux_ptrace_h = $(srcdir)/../common/linux-ptrace.h @@ -444,16 +445,16 @@ ax.o: ax.c $(server_h) $(ax_h) $(srcdir)/../common/ax.def event-loop.o: event-loop.c $(server_h) hostio.o: hostio.c $(server_h) hostio-errno.o: hostio-errno.c $(server_h) -inferiors.o: inferiors.c $(server_h) +inferiors.o: inferiors.c $(server_h) $(gdbthread_h) mem-break.o: mem-break.c $(server_h) $(ax_h) proc-service.o: proc-service.c $(server_h) $(gdb_proc_service_h) -regcache.o: regcache.c $(server_h) $(regdef_h) -remote-utils.o: remote-utils.c terminal.h $(server_h) -server.o: server.c $(server_h) $(agent_h) -target.o: target.c $(server_h) +regcache.o: regcache.c $(server_h) $(regdef_h) $(gdbthread_h) +remote-utils.o: remote-utils.c terminal.h $(server_h) $(gdbthread_h) +server.o: server.c $(server_h) $(agent_h) $(gdbthread_h) +target.o: target.c $(server_h) thread-db.o: thread-db.c $(server_h) $(linux_low_h) $(gdb_proc_service_h) \ $(gdb_thread_db_h) -tracepoint.o: tracepoint.c $(server_h) $(ax_h) $(agent_h) +tracepoint.o: tracepoint.c $(server_h) $(ax_h) $(agent_h) $(gdbthread_h) utils.o: utils.c $(server_h) gdbreplay.o: gdbreplay.c config.h dll.o: dll.c $(server_h) @@ -526,12 +527,12 @@ linux-xtensa-low.o: linux-xtensa-low.c xtensa-xtregs.c $(linux_low_h) $(server_h lynx-low.o: lynx-low.c $(server_h) $(target_h) $(lynx_low_h) lynx-ppc-low.o: lynx-ppc-low.c $(server_h) $(lynx_low_h) -nto-low.o: nto-low.c $(server_h) $(nto_low_h) +nto-low.o: nto-low.c $(server_h) $(nto_low_h) $(gdbthread_h) nto-x86-low.o: nto-x86-low.c $(server_h) $(nto_low_h) $(regdef_h) $(regcache_h) win32_low_h = $(srcdir)/win32-low.h -win32-low.o: win32-low.c $(win32_low_h) $(server_h) $(regdef_h) $(regcache_h) +win32-low.o: win32-low.c $(win32_low_h) $(server_h) $(regdef_h) $(regcache_h) $(gdbthread_h) win32-arm-low.o: win32-arm-low.c $(win32_low_h) $(server_h) win32-i386-low.o: win32-i386-low.c $(win32_low_h) $(server_h) $(i386_low_h) diff --git a/gdb/gdbserver/gdbthread.h b/gdb/gdbserver/gdbthread.h new file mode 100644 index 0000000..d863ec0 --- /dev/null +++ b/gdb/gdbserver/gdbthread.h @@ -0,0 +1,71 @@ +/* Multi-thread control defs for remote server for GDB. + Copyright (C) 1993, 1995, 1997-2000, 2002-2012 Free Software + Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#ifndef GDB_THREAD_H +#define GDB_THREAD_H + +#include "server.h" + +struct thread_info +{ + struct inferior_list_entry entry; + void *target_data; + void *regcache_data; + + /* The last resume GDB requested on this thread. */ + enum resume_kind last_resume_kind; + + /* The last wait status reported for this thread. */ + struct target_waitstatus last_status; + + /* Given `while-stepping', a thread may be collecting data for more + than one tracepoint simultaneously. E.g.: + + ff0001 INSN1 <-- TP1, while-stepping 10 collect $regs + ff0002 INSN2 + ff0003 INSN3 <-- TP2, collect $regs + ff0004 INSN4 <-- TP3, while-stepping 10 collect $regs + ff0005 INSN5 + + Notice that when instruction INSN5 is reached, the while-stepping + actions of both TP1 and TP3 are still being collected, and that TP2 + had been collected meanwhile. The whole range of ff0001-ff0005 + should be single-stepped, due to at least TP1's while-stepping + action covering the whole range. + + On the other hand, the same tracepoint with a while-stepping action + may be hit by more than one thread simultaneously, hence we can't + keep the current step count in the tracepoint itself. + + This is the head of the list of the states of `while-stepping' + tracepoint actions this thread is now collecting; NULL if empty. + Each item in the list holds the current step of the while-stepping + action. */ + struct wstep_state *while_stepping; +}; + +extern struct inferior_list all_threads; + +void remove_thread (struct thread_info *thread); +void add_thread (ptid_t ptid, void *target_data); + +struct thread_info *find_thread_ptid (ptid_t ptid); +struct thread_info *gdb_id_to_thread (unsigned int); + +#endif /* GDB_THREAD_H */ diff --git a/gdb/gdbserver/inferiors.c b/gdb/gdbserver/inferiors.c index 2b9169a..76abaf5 100644 --- a/gdb/gdbserver/inferiors.c +++ b/gdb/gdbserver/inferiors.c @@ -21,6 +21,7 @@ #include #include "server.h" +#include "gdbthread.h" struct inferior_list all_processes; struct inferior_list all_threads; diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h index a1a6777..59b897e 100644 --- a/gdb/gdbserver/linux-low.h +++ b/gdb/gdbserver/linux-low.h @@ -22,6 +22,7 @@ #endif #include +#include "gdbthread.h" #include "gdb_proc_service.h" #ifdef HAVE_LINUX_REGSETS diff --git a/gdb/gdbserver/nto-low.c b/gdb/gdbserver/nto-low.c index eabee10..bfff825 100644 --- a/gdb/gdbserver/nto-low.c +++ b/gdb/gdbserver/nto-low.c @@ -19,6 +19,7 @@ #include "server.h" +#include "gdbthread.h" #include "nto-low.h" #include diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index 5eda9df..5e4c149 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -19,6 +19,7 @@ #include "server.h" #include "regdef.h" +#include "gdbthread.h" #include #include diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index 995e3b1..0b3adac 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -19,6 +19,7 @@ #include "server.h" #include "terminal.h" #include "target.h" +#include "gdbthread.h" #include #include #if HAVE_SYS_IOCTL_H diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 23c9d47..b3d1b41 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -18,6 +18,7 @@ along with this program. If not, see . */ #include "server.h" +#include "gdbthread.h" #include "agent.h" #if HAVE_UNISTD_H diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h index 7f4c51a..225d07e 100644 --- a/gdb/gdbserver/server.h +++ b/gdb/gdbserver/server.h @@ -145,44 +145,7 @@ struct regcache; #include "gdb_signals.h" #include "target.h" #include "mem-break.h" - -struct thread_info -{ - struct inferior_list_entry entry; - void *target_data; - void *regcache_data; - - /* The last resume GDB requested on this thread. */ - enum resume_kind last_resume_kind; - - /* The last wait status reported for this thread. */ - struct target_waitstatus last_status; - - /* Given `while-stepping', a thread may be collecting data for more - than one tracepoint simultaneously. E.g.: - - ff0001 INSN1 <-- TP1, while-stepping 10 collect $regs - ff0002 INSN2 - ff0003 INSN3 <-- TP2, collect $regs - ff0004 INSN4 <-- TP3, while-stepping 10 collect $regs - ff0005 INSN5 - - Notice that when instruction INSN5 is reached, the while-stepping - actions of both TP1 and TP3 are still being collected, and that TP2 - had been collected meanwhile. The whole range of ff0001-ff0005 - should be single-stepped, due to at least TP1's while-stepping - action covering the whole range. - - On the other hand, the same tracepoint with a while-stepping action - may be hit by more than one thread simultaneously, hence we can't - keep the current step count in the tracepoint itself. - - This is the head of the list of the states of `while-stepping' - tracepoint actions this thread is now collecting; NULL if empty. - Each item in the list holds the current step of the while-stepping - action. */ - struct wstep_state *while_stepping; -}; +#include "gdbthread.h" struct dll_info { @@ -239,7 +202,6 @@ void initialize_low (); /* From inferiors.c. */ extern struct inferior_list all_processes; -extern struct inferior_list all_threads; extern struct inferior_list all_dlls; extern int dlls_changed; extern void clear_dlls (void); @@ -252,8 +214,6 @@ void for_each_inferior (struct inferior_list *list, extern struct thread_info *current_inferior; void remove_inferior (struct inferior_list *list, struct inferior_list_entry *entry); -void remove_thread (struct thread_info *thread); -void add_thread (ptid_t ptid, void *target_data); struct process_info *add_process (int pid, int attached); void remove_process (struct process_info *process); @@ -261,12 +221,10 @@ struct process_info *find_process_pid (int pid); int have_started_inferiors_p (void); int have_attached_inferiors_p (void); -struct thread_info *find_thread_ptid (ptid_t ptid); - ptid_t thread_id_to_gdb_id (ptid_t); ptid_t thread_to_gdb_id (struct thread_info *); ptid_t gdb_id_to_thread_id (ptid_t); -struct thread_info *gdb_id_to_thread (unsigned int); + void clear_inferiors (void); struct inferior_list_entry *find_inferior (struct inferior_list *, diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index 959dba0..6e59650 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -17,6 +17,7 @@ along with this program. If not, see . */ #include "server.h" +#include "gdbthread.h" #include "agent.h" #include diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c index 3e10490..315d449 100644 --- a/gdb/gdbserver/win32-low.c +++ b/gdb/gdbserver/win32-low.c @@ -24,6 +24,7 @@ #include "gdb/fileio.h" #include "mem-break.h" #include "win32-low.h" +#include "gdbthread.h" #include #include -- 1.7.0.4