Re: [PATCH] Link gnulib in gdbserver.

Jan Kratochvil
2012-04-13T21:26:27Z

On Wed, 11 Apr 2012 08:50:46 +0200, Yao Qi wrote:
> 2012-04-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Define abs_top_srcdir and abs_srcdir.
> (INCLUDE_CFLAGS): Append GNULIB_INCLUDE_DIR.
> (install-only, install-info:, clean:): Handle sub dir gnulib.
> (all-lib, am--refresh): New target.
> (memmem.o): Remove target.
> * configure.ac: Remove AC_CONFIG_LIBOBJ_DIR.
> Invoke gl_EARLY. Invoke AC_CHECK_PROGS for make.
> (AC_REPLACE_FUNCS): Remove memmem.
> Invoke gl_INIT and AM_INIT_AUTOMAKE.
> (AC_OUTPUT): Generate Makefile in gnulib/.
> * aclocal.m4, config.in, configure: Regenerated.

This broken in-src-tree build:

make[7]: Entering directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver/gnulib'
make[7]: Nothing to be done for `all-am'.
make[7]: Leaving directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver/gnulib'
[...]
gcc -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -I. -I. -I./../common -I./../regformats -I./../../include -I./../gnulib -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Werror -lmcheck -Wl,--dynamic-list=./proc-service.list -o gdbserver agent.o ax.o inferiors.o regcache.o remote-utils.o server.o signals.o target.o utils.o version.o mem-break.o hostio.o event-loop.o tracepoint.o xml-utils.o common-utils.o ptid.o buffer.o dll.o xml-builtin.o amd64-linux.o amd64-avx-linux.o x32-linux.o x32-avx-linux.o i386-linux.o i386-avx-linux.o i386-mmx-linux.o linux-low.o linux-osdata.o linux-x86-low.o i386-low.o i387-fp.o linux-procfs.o linux-ptrace.o hostio-errno.o thread-db.o proc-service.o \
gnulib/libgnu.a -ldl
gcc: error: gnulib/libgnu.a: No such file or directory
make[4]: *** [gdbserver] Error 1
make[4]: Leaving directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver'

I do not like there the VPATH tricks etc., there should be some full copy of
gnulib IMO.

Regards,
Jan