From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21063 invoked by alias); 18 Apr 2012 12:41:06 -0000 Received: (qmail 20996 invoked by uid 22791); 18 Apr 2012 12:41:03 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 12:40:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3ICeKmx019113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Apr 2012 08:40:20 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3ICeIZI026113; Wed, 18 Apr 2012 08:40:19 -0400 Message-ID: <4F8EB632.6050501@redhat.com> Date: Wed, 18 Apr 2012 12:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: Joel Brobecker , Yao Qi , gdb-patches@sourceware.org Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR. References: <4F8BFB25.5030808@redhat.com> <4F8C5794.5050302@redhat.com> <20120416174339.GA11991@host2.jankratochvil.net> <4F8D9F1E.2070203@redhat.com> <20120417170521.GA9906@host2.jankratochvil.net> <4F8DA538.1060000@redhat.com> <20120417232552.GS2852@adacore.com> <4F8E860F.8050906@redhat.com> <20120418092859.GA5887@host2.jankratochvil.net> <4F8E949E.1000702@redhat.com> <20120418123254.GA11744@host2.jankratochvil.net> In-Reply-To: <20120418123254.GA11744@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00560.txt.bz2 On 04/18/2012 01:32 PM, Jan Kratochvil wrote: > On Wed, 18 Apr 2012 12:17:02 +0200, Pedro Alves wrote: >> GNULIB_CFLAGS=-I$(srcdir)/gnulib/import -I$(GNULIB_BUILDDIR)/import >> >> isn't that confusing. $(GNULIB_BUILDDIR)/import is the build of >> the gnulib import. >> >> Would that make everybody happy? > > IIUC there are still two directories containing different kinds of files while > having the same basename. I'm not sure what you mean. The proposal is to move: Move src/gdb/gnulib -> src/gdb/gnulib/import/ Then src/gdb/gnulib/ gains new autoconf/makefile glue. When building src/gdb/gnulib/, the build descends into gnulib/import/, and builds that, just like when building src/, we descend into src/gdb/ -> build/gdb , and then descent into src/gdb/gdbserver/ -> build/gdb/gdbserver/ . gnulib generates headers when it is built. We need to point the compiler at both the gnulib sources, and to those generated headers. Hence, GNULIB_CFLAGS=-I$(srcdir)/gnulib/import -I$(GNULIB_BUILDDIR)/import The first -I is the gnulib imported sources, the second -I is the built gnulib, which contains the generated headers. This is no different from src/gdb/ vs build/gdb. Does that clear things up? -- Pedro Alves