Re: [PATCH] Link gnulib in gdbserver.

Pedro Alves
2012-04-13T13:17:08Z

On 04/13/2012 12:48 PM, Yao Qi wrote:

> On 04/13/2012 07:05 PM, Pedro Alves wrote:

>> I tried it, and things still appear to build fine. IOW, is there a case
>> where building gnulib would need to find something in the gdbserver source dir?
>
> IIRC, I append "$(abs_top_srcdir)" in VPATH because gnulib finds file
> `configure' for `config.status' in some dependency. Now, I remove it
> from VPATH, but unable to get a build error, which means we can remove
> $(abs_top_srcdir) from VPATH, and my memory is bad :)

Actually, I just tried again, and things break.

make[1]: Entering directory `/home/pedro/gdb/mygit/build-gdbserver/gnulib'
make[1]: *** No rule to make target `string.in.h', needed by `string.h'. Stop.
make[1]: Leaving directory `/home/pedro/gdb/mygit/build-gdbserver/gnulib'
make: *** [all-lib] Error 2

I also noticed that make'ing from within gdbserver/gnulib doesn't work,
only when built from gdbserver. Makes sense given the way we're overriding
the make variables. Doesn't bother me, but makes me think there's probably
a better way, involving setting srcdir&friends at autoconf time instead
(though I don't know how).

> Patch looks good to me. Thanks.

Thanks, I've applied it.

--
Pedro Alves