From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8568 invoked by alias); 17 Apr 2012 16:50:02 -0000 Received: (qmail 8505 invoked by uid 22791); 17 Apr 2012 16:49:58 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 16:49:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HGnaES023514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Apr 2012 12:49:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3HGnYan006960; Tue, 17 Apr 2012 12:49:35 -0400 Message-ID: <4F8D9F1E.2070203@redhat.com> Date: Tue, 17 Apr 2012 16:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <20120413212559.GA5867@host2.jankratochvil.net> <4F88F188.1050401@codesourcery.com> <20120415164917.GA2861@host2.jankratochvil.net> <4F8BFB25.5030808@redhat.com> <4F8C5794.5050302@redhat.com> <20120416174339.GA11991@host2.jankratochvil.net> In-Reply-To: <20120416174339.GA11991@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00501.txt.bz2 On 04/16/2012 06:43 PM, Jan Kratochvil wrote: > On Mon, 16 Apr 2012 19:32:04 +0200, Pedro Alves wrote: >> Follows the patch. What do you all think? > > I agree in general. I would rename gnulib/gnulib/ to some unique names > instead, it is a mess. I tried to come up with something, but it isn't easy (to me). I thought of: gnulib/src/ gnulib/import/ but that ends up with the confusing: GNULIB_CFLAGS=-I$(srcdir)/gnulib/src -I$(GNULIB_BUILDDIR)/src Confusing because $(GNULIB_BUILDDIR)/src isn't really src, but the built libgnu.a and the generated headers. I thought of calling the wrapper dir libgnu, so: libgnu/gnulib/ which yields: GNULIB_CFLAGS=-I$(srcdir)/libgnu/gnulib -I$(GNULIB_BUILDDIR)/gnulib or perhaps: LIBGNU_CFLAGS=-I$(srcdir)/libgnu/gnulib -I$(LIBGNU_BUILDDIR)/gnulib Or another option: gnulib-wrapper/gnulib/ which looks ugly to me. So, so far, I'm torn between: libgnu/gnulib/ gnulib/gnulib/ Any other options? Preferences? -- Pedro Alves