Re: [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix

Joel Brobecker
2012-04-18T00:32:13Z

> gdb/ChangeLog:
>
> * xcoffread.c (xcoff_secnum_to_sections): New function.
> (secnum_to_section, secnum_to_bfd_section): Reimplement
> using xcoff_secnum_to_sections. Rename "secnum" parameter
> into "n_scnum".
> (RECORD_MINIMAL_SYMBOL): Delete.
> (record_minimal_symbol): New function.
> (scan_xcoff_symtab): Replace uses of RECORD_MINIMAL_SYMBOL
> by call to record_minimal_symbol and set misc_func_recorded
> to 1. Set last_csect_sec to the XCOFF section index instead
> of GDB's section_offset index. Update calls to
> prim_record_minimal_symbol_and_info to pass the BFD section
> as well.

Unfortunately, as explained at
http://www.sourceware.org/ml/gdb-patches/2012-04/msg00523.html, I was
not able to test this patch against the official testsuite. I think
it's an expect problem on AIX, and I did take the time a long time
to look into the expect sources, and fix some of the problems I faced
at the time. But I don't want to do that again, not for AIX.

As far as I am concerned, I am satisfied with just running the
AdaCore testsuite, where it shows no regression, and I think it
is an overall improvement as well. I don't know if anyone else really
cares about that port? In the meantime, I have checked the patch in.
It's easy to revert if there are objections.

--
Joel