From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18150 invoked by alias); 17 Apr 2012 10:25:25 -0000 Received: (qmail 18139 invoked by uid 22791); 17 Apr 2012 10:25:24 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 10:25:10 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SK5av-0002qi-5Z from Yao_Qi@mentor.com ; Tue, 17 Apr 2012 03:25:09 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 17 Apr 2012 03:25:08 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Tue, 17 Apr 2012 03:25:07 -0700 Message-ID: <4F8D450C.9070000@codesourcery.com> Date: Tue, 17 Apr 2012 10:29:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Jan Kratochvil , Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <20120413212559.GA5867@host2.jankratochvil.net> <4F88F188.1050401@codesourcery.com> <20120415164917.GA2861@host2.jankratochvil.net> <4F8BFB25.5030808@redhat.com> <4F8C5794.5050302@redhat.com> In-Reply-To: <4F8C5794.5050302@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00453.txt.bz2 On 04/17/2012 01:32 AM, Pedro Alves wrote: > diff --git c/gdb/acx_configure_dir.m4 w/gdb/acx_configure_dir.m4 > new file mode 100644 > index 0000000..822e882 > --- /dev/null > +++ w/gdb/acx_configure_dir.m4 > @@ -0,0 +1,104 @@ > +# ACX_CONFIGURE_DIR(SRC-DIR-NAME, BUILD-DIR-NAME) > +# --------------------------- > +# > +# Configure a subdirectory. This is an alternative to > +# AC_CONFIG_SUBDIRS that allows pointing the source directory > +# somewhere else. The build directory is always a subdirectory of the > +# top build directory. This is heavilly based on autoconf's > +# _AC_OUTPUT_SUBDIRS. > +# > +# Inputs: > +# - SRC-DIR-NAME is the source directory, relative to $srcdir. > +# - BUILD-DIR-NAME is `top-build -> build' Do we need a copyright header here? > diff --git c/gdb/defs.h w/gdb/defs.h > index 1075111..af66b00 100644 > --- c/gdb/defs.h > +++ w/gdb/defs.h > @@ -26,6 +26,7 @@ > # error gdbserver should not include gdb/defs.h > #endif > > +#include "build-gnulib/../config.h" It should be "build-gnulib/config.h". I noticed you've fixed it in your git tree, so it is not a problem. -- Yao (齐尧)