From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31313 invoked by alias); 16 Apr 2012 15:03:46 -0000 Received: (qmail 31303 invoked by uid 22791); 16 Apr 2012 15:03:45 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 15:03:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3GF36ND014279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Apr 2012 11:03:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3GF34g7002601; Mon, 16 Apr 2012 11:03:05 -0400 Message-ID: <4F8C34A8.30101@redhat.com> Date: Mon, 16 Apr 2012 15:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Siva Chandra , gdb-patches@sourceware.org Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE References: <20120416144401.GI2852@adacore.com> In-Reply-To: <20120416144401.GI2852@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00419.txt.bz2 On 04/16/2012 03:44 PM, Joel Brobecker wrote: > Hello Siva, > >> 2012-04-16 Siva Chandra Reddy >> >> * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches >> when accessing the CVS repository. Add a note saying that the >> "-up" flavors of "cvs diff" and "diff" are preferred. > > Thanks for doing that. > > Personally, I'd even get rid of the "diff -cp" alternative. We'll > continue accepting context diffs, but I think that suggesting it, > even if we say later on that we prefer unified diffs, will result > in more patches sent in that format. Completely agreed. /me pokes at Stan. :-) > If we do not want to remove > the context diff alternative, then at least let's put it second. > > What do others think? -- Pedro Alves