Re: [PATCH] Link gnulib in gdbserver.

Yao Qi
2012-04-13T11:49:22Z

On 04/13/2012 07:05 PM, Pedro Alves wrote:
> So I think this is better, and actually cleaner, for keeping FLAGS_TO_PASS
> as it was, the gnulib specifics closer to gnulib code, and actually adding a
> comment just around the gnulib specific GNULIB_FLAGS_TO_PASS. :-)
>

Agreed. All these flags are gnulib specific so far.
GNULIB_FLAGS_TO_PASS is cleaner.

> BTW, is it really necessary to VPATH set to:
>
> VPATH=$(abs_top_srcdir)/../gnulib:$(abs_top_srcdir)"
>
> instead of just:
>
> VPATH=$(abs_top_srcdir)/../gnulib"
>
> I tried it, and things still appear to build fine. IOW, is there a case
> where building gnulib would need to find something in the gdbserver source dir?

IIRC, I append "$(abs_top_srcdir)" in VPATH because gnulib finds file
`configure' for `config.status' in some dependency. Now, I remove it
from VPATH, but unable to get a build error, which means we can remove
$(abs_top_srcdir) from VPATH, and my memory is bad :)

Patch looks good to me. Thanks.

--
Yao (é½å°§)