Re: [patch] Create cleanups.[ch]

Pedro Alves
2012-04-16T10:51:10Z

On 04/16/2012 06:00 AM, Sergio Durigan Junior wrote:
> Thanks, I'm always in favor of such API separations. Sorry for
> nitpicking, I know you are just moving the code around, but since you
> touched it I felt I should take a look even if it's old code (maybe,
> *especially* because of that!).

Note any such changes should best be done as separate changes. It's best
to separate code motion from other changes.

This made me notice that make_my_cleanup was unexported, and made static in
this patch, but note how that goes by mostly unnoticed (at least it was
to me on first sight). I'd have preferred that had been done as an independent
preparatory patch. I've now checked insight/gdbtk, to see if it was making
using use of it of those symbols, just in case, which would mean
in addition that CLEANUP_FENCEPOST in the other patch would also need to
be exported, and, it's not.

> It should be:

>
> Copyright (C) 2012 Free Software Foundation, Inc.
>
> AFAIK, since it's a new file.

But the contents are not new. By that reasoning, if we renamed
every file in the tree, while changing nothing else, all the copyright
years would end up 2012 only. I don't think that'd be right.

--
Pedro Alves