From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17659 invoked by alias); 16 Apr 2012 10:51:10 -0000 Received: (qmail 17649 invoked by uid 22791); 16 Apr 2012 10:51:09 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 10:50:46 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3GAojwH007589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Apr 2012 06:50:45 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3GAohvf013032; Mon, 16 Apr 2012 06:50:44 -0400 Message-ID: <4F8BF983.2090204@redhat.com> Date: Mon, 16 Apr 2012 10:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] Create cleanups.[ch] References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00409.txt.bz2 On 04/16/2012 06:00 AM, Sergio Durigan Junior wrote: > Thanks, I'm always in favor of such API separations. Sorry for > nitpicking, I know you are just moving the code around, but since you > touched it I felt I should take a look even if it's old code (maybe, > *especially* because of that!). Note any such changes should best be done as separate changes. It's best to separate code motion from other changes. This made me notice that make_my_cleanup was unexported, and made static in this patch, but note how that goes by mostly unnoticed (at least it was to me on first sight). I'd have preferred that had been done as an independent preparatory patch. I've now checked insight/gdbtk, to see if it was making using use of it of those symbols, just in case, which would mean in addition that CLEANUP_FENCEPOST in the other patch would also need to be exported, and, it's not. > It should be: > > Copyright (C) 2012 Free Software Foundation, Inc. > > AFAIK, since it's a new file. But the contents are not new. By that reasoning, if we renamed every file in the tree, while changing nothing else, all the copyright years would end up 2012 only. I don't think that'd be right. -- Pedro Alves