From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9340 invoked by alias); 13 Apr 2012 13:17:08 -0000 Received: (qmail 9021 invoked by uid 22791); 13 Apr 2012 13:17:05 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 13:16:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3DDGlQZ014473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Apr 2012 09:16:48 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3DDGkYR023744; Fri, 13 Apr 2012 09:16:47 -0400 Message-ID: <4F88273E.7090807@redhat.com> Date: Fri, 13 Apr 2012 13:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Yao Qi CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH] Link gnulib in gdbserver. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <4F85C251.1070705@redhat.com> <4F867BA5.40201@codesourcery.com> <4F8774DC.4040004@codesourcery.com> <4F88088D.5030601@redhat.com> <4F881299.2010300@codesourcery.com> In-Reply-To: <4F881299.2010300@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00355.txt.bz2 On 04/13/2012 12:48 PM, Yao Qi wrote: > On 04/13/2012 07:05 PM, Pedro Alves wrote: >> I tried it, and things still appear to build fine. IOW, is there a case >> where building gnulib would need to find something in the gdbserver source dir? > > IIRC, I append "$(abs_top_srcdir)" in VPATH because gnulib finds file > `configure' for `config.status' in some dependency. Now, I remove it > from VPATH, but unable to get a build error, which means we can remove > $(abs_top_srcdir) from VPATH, and my memory is bad :) Actually, I just tried again, and things break. make[1]: Entering directory `/home/pedro/gdb/mygit/build-gdbserver/gnulib' make[1]: *** No rule to make target `string.in.h', needed by `string.h'. Stop. make[1]: Leaving directory `/home/pedro/gdb/mygit/build-gdbserver/gnulib' make: *** [all-lib] Error 2 I also noticed that make'ing from within gdbserver/gnulib doesn't work, only when built from gdbserver. Makes sense given the way we're overriding the make variables. Doesn't bother me, but makes me think there's probably a better way, involving setting srcdir&friends at autoconf time instead (though I don't know how). > Patch looks good to me. Thanks. Thanks, I've applied it. -- Pedro Alves