On 04/12/2012 01:32 AM, Keith Seitz wrote:
> I don't normally chime in on patches, but I felt compelled to ask for
> one change in your patch (which otherwise looks okay to me):
> 
> On 04/11/2012 06:06 AM, Yao Qi wrote:
>>
>> +/* Invoke CALLBACK for each of bp_location.  */
>> +
>> +void
>> +iterate_over_bp_locations (void (*callback) (struct bp_location *))
>> +{
>> +  struct bp_location *loc, **loc_tmp;
>> +
>> +  ALL_BP_LOCATIONS (loc, loc_tmp)
>> +    {
>> +      callback (loc);
>> +    }
>> +}
>> +
> 
> Can you please define a typedef for this CALLBACK parameter?
> 

This updated patch addresses both Keith's and Doug's comments.  I
realize that this change is user visible, so add one entry in NEWS.

If no objections, I'll check it in in three or four days.

-- 
Yao (齐尧)