From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89785-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20234 invoked by alias); 12 Apr 2012 19:40:34 -0000
Received: (qmail 20225 invoked by uid 22791); 12 Apr 2012 19:40:33 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Apr 2012 19:40:16 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3CJeDs1012118	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 12 Apr 2012 15:40:13 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3CJeB06021024;	Thu, 12 Apr 2012 15:40:12 -0400
Message-ID: <4F872F9B.7090207@redhat.com>
Date: Thu, 12 Apr 2012 20:14:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: "H.J. Lu" <hongjiu.lu@intel.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Convert siginfo for x32 in gdbserver
References: <20120412172000.GA7985@intel.com>
In-Reply-To: <20120412172000.GA7985@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00320.txt.bz2

On 04/12/2012 06:20 PM, H.J. Lu wrote:

>  /* Convert a native/host siginfo object, into/from the siginfo in the
> @@ -938,6 +1113,21 @@ x86_siginfo_fixup (siginfo_t *native, void *inf, int direction)
>  
>        return 1;
>      }
> +  /* No fixup for native x32 GDB.  */
> +  else if (sizeof (void *) == 8)


I'm confused.  Isn't this _also_ reached when both the inferior and gdbserver are 64-bit?
There should also be no fixup then.

> +    {
> +      if (sizeof (siginfo_t) != sizeof (compat_siginfo_t))


      if (sizeof (siginfo_t) != sizeof (compat_x32_siginfo_t))

> +	fatal ("unexpected difference in siginfo");
> +
> +      if (direction == 0)
> +	compat_x32_siginfo_from_siginfo ((struct compat_x32_siginfo *) inf,
> +					 native);
> +      else
> +	siginfo_from_compat_x32_siginfo (native,
> +					 (struct compat_x32_siginfo *) inf);
> +
> +      return 1;
> +    }
>  #endif
>  



-- 
Pedro Alves