From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89778-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1450 invoked by alias); 12 Apr 2012 16:53:52 -0000
Received: (qmail 1438 invoked by uid 22791); 12 Apr 2012 16:53:47 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Apr 2012 16:53:31 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3CGrTjx018488	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 12 Apr 2012 12:53:29 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3CGrS8V021462;	Thu, 12 Apr 2012 12:53:28 -0400
Message-ID: <4F870888.9020803@redhat.com>
Date: Thu, 12 Apr 2012 17:20:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR gdb/13969: GDBserver doesn't check unsupported binary
References: <20120411191609.GA466@intel.com> <4F86D411.4000100@redhat.com> <CAMe9rOpYBe62K_0X3mFMYiQOC0dQLT9yf5TBNgEqiQUifQgdyQ@mail.gmail.com> <4F86FB82.7030308@redhat.com> <CAMe9rOoQOhMdgx=wbXBbZ03-a+cRsecSwA97+kOtiZjzHk_+DA@mail.gmail.com> <4F8704F9.9040309@redhat.com> <CAMe9rOpeuuzu-3ZHien3XCfXVi2pcXeLC-6Ap8jbXUk+hA2Dhw@mail.gmail.com>
In-Reply-To: <CAMe9rOpeuuzu-3ZHien3XCfXVi2pcXeLC-6Ap8jbXUk+hA2Dhw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00313.txt.bz2

On 04/12/2012 05:45 PM, H.J. Lu wrote:

> x32 ptrace returns x32 siginfo, 


ok.

> which is compatible with ia32 inferior


I believe clock_t will be 64-bit with x32, however, right?
If so, amd64-linux-nat.c:compat_siginfo_from_siginfo|siginfo_from_compat_siginfo
(and the gdbserver equivalents) will need adjustment (for the 64-bit X x32 case).
This is something most probably not caught by the testsuite.

-- 
Pedro Alves