From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29018 invoked by alias); 11 Apr 2012 18:11:56 -0000 Received: (qmail 28995 invoked by uid 22791); 11 Apr 2012 18:11:54 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 18:11:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3BIBGFr026971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Apr 2012 14:11:38 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3BHWNUF029324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 11 Apr 2012 13:32:25 -0400 Message-ID: <4F85C027.3010105@redhat.com> Date: Wed, 11 Apr 2012 18:15:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] breakpoint always inserted in record target References: <1334149619-2738-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1334149619-2738-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00257.txt.bz2 I don't normally chime in on patches, but I felt compelled to ask for one change in your patch (which otherwise looks okay to me): On 04/11/2012 06:06 AM, Yao Qi wrote: > > +/* Invoke CALLBACK for each of bp_location. */ > + > +void > +iterate_over_bp_locations (void (*callback) (struct bp_location *)) > +{ > + struct bp_location *loc, **loc_tmp; > + > + ALL_BP_LOCATIONS (loc, loc_tmp) > + { > + callback (loc); > + } > +} > + Can you please define a typedef for this CALLBACK parameter? Keith