Re: [PATCH v2] Add autoload-breakpoints [6/6] autoload-breakpoints doc

Eli Zaretskii
2012-04-28T08:25:45Z

> Date: Sat, 28 Apr 2012 15:15:33 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: <gdb-patches@sourceware.org>
>
> >>> This part is not very clear. What about following part?
> >>>
> >>> When @value{GDBN} get this packet, it will delete this breakpoint
> >>> as it have been removed in the target. So when the target send
> >>> this packet, it needs to remove these breakpoints in local part by itself.
> >>
> >> Who is sending this packet, the target or GDB? I understand that the
> >> target sends it, because you say "when GDB gets this packet".
> >>
> > Yes, the target send it.
> >
> >> But if the target sends this packet, then it should be quite clear
> >> that it (the target) should delete the breakpoint.
> >
> > In prev version, GDB will send delete cmd to target when it got a autoload-breakpoint R to delete them. But I thought it will be hard to handle in both for target and GDB.
> > So I change it: GDB will not send delete cmd after get the autoload-breakpoints R packet, the target will remove them by itself.
> >
> > In fact, I would
> >> expect the packet to be a side effect of deletion on the target side.
> >> Is the above correct?
> >
> > Yes.
> >
> > Thanks,
> > Hui
>
> Ping.

Please send me a fixed patch to review, I don't think you sent one
after our last exchange.

Thanks.