From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4395 invoked by alias); 11 Apr 2012 05:44:24 -0000 Received: (qmail 4385 invoked by uid 22791); 11 Apr 2012 05:44:22 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_XP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 05:44:08 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SHqLe-00034s-Hw from Hui_Zhu@mentor.com ; Tue, 10 Apr 2012 22:44:06 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 10 Apr 2012 22:43:50 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 10 Apr 2012 22:44:05 -0700 Message-ID: <4F851A22.40809@mentor.com> Date: Wed, 11 Apr 2012 05:58:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Tom Tromey , Subject: Re: [PATCH]testsuite: test for disconnected-tracing References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com> <4F7D8715.9040509@redhat.com> In-Reply-To: <4F7D8715.9040509@redhat.com> Content-Type: multipart/mixed; boundary="------------040300030604020902080001" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00228.txt.bz2 --------------040300030604020902080001 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1448 On 04/05/12 19:50, Pedro Alves wrote: > On 04/05/2012 09:14 AM, Hui Zhu wrote: > >> I post a new version patch according to your comments. >> And I have test it with gdb-7.4 and got fail. > > > Thanks. Only a few nits remain, and this is technically ready to > check in. See below. > > However, what's the status of your copyright assignment? Last I > heard (and from what I see in FSF's copyright assignment records), we > still can't accept changes from you on behalf of Mentor. :-( What I got is it is OK now. I will send you a mail and cc the people that about the law. > >> 2012-04-05 Hui Zhu >> >> * gdb.trace/Makefile.in (PROGS): Add >> disconnected-tracing. > > > This fits fine on a single line. Please do that. > >> * gdb.trace/disconnected-tracing.c: New file. >> * gdb.trace/disconnected-tracing.exp: New file. >> > > >> --- /dev/null >> +++ b/testsuite/gdb.trace/disconnected-tracing.c > > ... > >> + >> +int >> +main() > > > Might as well follow the coding standards, and add a space before parens. > >> +{ >> + return 0; >> +} >> \ No newline at end of file > > ^^^^^^^^^^^^^^^^^^^^^^^^^ > > Please add a newline. > Post a new version according to your commnets. Thanks, Hui 2012-04-11 Hui Zhu * gdb.trace/Makefile.in (PROGS): Add disconnected-tracing. * gdb.trace/disconnected-tracing.c: New file. * gdb.trace/disconnected-tracing.exp: New file. --------------040300030604020902080001 Content-Type: text/plain; charset="us-ascii"; name="disconnected-tracing.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="disconnected-tracing.txt" Content-length: 3904 --- testsuite/gdb.trace/Makefile.in | 2 testsuite/gdb.trace/disconnected-tracing.c | 21 +++++++ testsuite/gdb.trace/disconnected-tracing.exp | 76 +++++++++++++++++++++++++++ 3 files changed, 98 insertions(+), 1 deletion(-) --- a/testsuite/gdb.trace/Makefile.in +++ b/testsuite/gdb.trace/Makefile.in @@ -5,7 +5,7 @@ srcdir = @srcdir@ PROGS = ax backtrace deltrace infotrace packetlen passc-dyn passcount \ report save-trace tfile tfind tracecmd tsv unavailable while-dyn \ - while-stepping + while-stepping disconnected-tracing all info install-info dvi install uninstall installcheck check: @echo "Nothing to be done for $@..." --- /dev/null +++ b/testsuite/gdb.trace/disconnected-tracing.c @@ -0,0 +1,21 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2012 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +int main () +{ + return 0; +} --- /dev/null +++ b/testsuite/gdb.trace/disconnected-tracing.exp @@ -0,0 +1,76 @@ +# Copyright 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test of disconnected-tracing. + +load_lib "trace-support.exp"; + +set testfile "disconnected-tracing" +set executable $testfile +set srcfile ${testfile}.c +set binfile $objdir/$subdir/$testfile +set expfile $testfile.exp +set gdbserver_reconnect_p 1 + +if { [info proc gdb_reconnect] == "" } { + unsupported "target does not support reconnect" + return -1 +} + +if [prepare_for_testing $expfile $executable $srcfile \ + {debug nowarnings}] { + untested "failed to prepare for trace tests" + return -1 +} + +if ![runto_main] { + fail "can't run to main to check for trace support" + return -1 +} + +if ![gdb_target_supports_trace] { + unsupported "target does not support trace" + return -1; +} + +delete_breakpoints +gdb_test_no_output "set confirm off" +gdb_test_no_output "set disconnected-tracing on" +gdb_test "trace main" ".*" +gdb_test_no_output "tstart" + +gdb_test "info tracepoints" ".*in main at.*" "First info tracepoints" + +gdb_test "disconnect" "Ending remote debugging\\." +if { [gdb_reconnect] == 0 } { + pass "reconnect after unload" +} else { + fail "reconnect after unload" + return 0 +} +gdb_test "info tracepoints" ".*in main at.*" "Second info tracepoints" + +delete_breakpoints +gdb_test "info tracepoints" ".*No tracepoints..*" "Third info tracepoints" + +gdb_test "disconnect" "Ending remote debugging\\." +if { [gdb_reconnect] == 0 } { + pass "reconnect after unload" +} else { + fail "reconnect after unload" + return 0 +} +gdb_test "info tracepoints" ".*in main at.*" "Fourth info tracepoints" + --------------040300030604020902080001--