From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8774 invoked by alias); 5 Apr 2012 11:51:04 -0000 Received: (qmail 8762 invoked by uid 22791); 5 Apr 2012 11:51:03 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 11:50:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q35Bolln014166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Apr 2012 07:50:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q35BojER013293; Thu, 5 Apr 2012 07:50:46 -0400 Message-ID: <4F7D8715.9040509@redhat.com> Date: Thu, 05 Apr 2012 11:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Hui Zhu CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH]testsuite: test for disconnected-tracing References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com> In-Reply-To: <4F7D5456.9080806@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00062.txt.bz2 On 04/05/2012 09:14 AM, Hui Zhu wrote: > I post a new version patch according to your comments. > And I have test it with gdb-7.4 and got fail. Thanks. Only a few nits remain, and this is technically ready to check in. See below. However, what's the status of your copyright assignment? Last I heard (and from what I see in FSF's copyright assignment records), we still can't accept changes from you on behalf of Mentor. :-( > 2012-04-05 Hui Zhu > > * gdb.trace/Makefile.in (PROGS): Add > disconnected-tracing. This fits fine on a single line. Please do that. > * gdb.trace/disconnected-tracing.c: New file. > * gdb.trace/disconnected-tracing.exp: New file. > > --- /dev/null > +++ b/testsuite/gdb.trace/disconnected-tracing.c ... > + > +int > +main() Might as well follow the coding standards, and add a space before parens. > +{ > + return 0; > +} > \ No newline at end of file ^^^^^^^^^^^^^^^^^^^^^^^^^ Please add a newline. -- Pedro Alves