Re: [PATCH] Add autoload-breakpoints [3/7] ReportAsync-doc

Hui Zhu
2012-03-20T13:25:47Z

Hi Eli,

Thank you for your help.

On 03/17/12 18:12, Eli Zaretskii wrote:
>> Date: Sat, 17 Mar 2012 16:52:34 +0800
>> From: Hui Zhu<hui_zhu@mentor.com>
>> CC: Stan Shebs<stan_shebs@mentor.com>
>>
>> This is patch for the doc about ReportAsync.
>
> Thanks.
>
>> +The @value{GDBN} remote serial protocol includes @dfn{reportasync},
>> +packets that the stub can report status or do an operation in any time.
>
> I don't understand the "do an operation in any time" part. What does
> it mean in practice?

It is means that after gdb connected with the stub, the stub can report
when the inferior is running and GDB is waiting it, or inferior is
stoped and GDB just control it.
It make the stub can report the status for any time.

I didn't have good words on this part to make it more clear. Could you
help me with it?

>
> When the stub wants to send a @samp{reportasync} packet, it first sends
> a handshake packet @samp{^} to @value{GDBN}.
>
>> +If @value{GDBN} reply a @samp{^}, the shake hands is successful.
>
> If @value{GDBN} replies with a @samp{^}, the handshake is successful.
>
>> +If not, the shake hands is fail and this packet need to be handle
>> +as a simple packet.
>
> If not, the handshake fails, and the @samp{reportasync} packet needs
> to be handled as a simple packet.

I will fix them.

>
> And I don't understand what you mean by "needs to be handled as a
> simple packet". If that's a reference to something discussed earlier
> in the manual, please add here a cross-reference to that part.

That means when the stub send a shake hands package ^ and wait the
reply, if it got a package that is not ^. Then the shake hands is fail.
It need give up this shake hands and begin to handle this packet that
it just get.
For example:
Stub send a ^ to GDB. It readchar, and got a $. It should not drop
this $, After that, it will got "c#csum". It need handle the package
"$c#csum".
My words in the doc is not very clear, could you help me with it?

>
>> +After shake hands, the stub can send packet to @value{GDBN}, the packet
>> +format is same with simple remote serial protocol.
>
> After the handshake, the stub can send @samp{reportasync} packets to
> @value{GDBN}, using the same packet format as in simple remote serial
> protocol.
>
> Is this only for the failed handshake? If so, perhaps we need to tell
> what happens when the handshake succeeds.

No, this is for success.
What about I change it to:
After the handshake success, the stub can send @samp{reportasync}
packets to @value{GDBN}, using the same packet format as in simple
remote serial protocol.

Best,
Hui