From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32458 invoked by alias); 30 Mar 2012 20:11:14 -0000 Received: (qmail 32447 invoked by uid 22791); 30 Mar 2012 20:11:12 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from forward14.mail.yandex.net (HELO forward14.mail.yandex.net) (95.108.130.92) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 20:10:57 +0000 Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68]) by forward14.mail.yandex.net (Yandex) with ESMTP id 818CD19825CF; Sat, 31 Mar 2012 00:10:54 +0400 (MSK) Received: from smtp13.mail.yandex.net (localhost [127.0.0.1]) by smtp13.mail.yandex.net (Yandex) with ESMTP id 53F1AE4038F; Sat, 31 Mar 2012 00:10:54 +0400 (MSK) Received: from kts.bestnet.kharkov.ua (kts.bestnet.kharkov.ua [80.92.226.138]) by smtp13.mail.yandex.net (nwsmtp/Yandex) with ESMTP id ArB8NCEo-ArB85Cfa; Sat, 31 Mar 2012 00:10:54 +0400 Message-ID: <4F7613A1.3040600@yandex.ru> Date: Fri, 30 Mar 2012 20:11:00 -0000 From: xgsa User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.27) Gecko/20120216 Thunderbird/3.1.19 MIME-Version: 1.0 To: Tom Tromey CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: set print object on should affect MI varobjs (PR mi/13393) References: <4ED92C05.9080803@yandex.ru> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> <4F32C009.2050103@yandex.ru> <87pqdma1mo.fsf@fleche.redhat.com> <4F412637.2010405@yandex.ru> <4F660CF6.9070008@yandex.ru> <8339953anu.fsf@gnu.org> <4F66DBD0.4000903@yandex.ru> <83vcm01obe.fsf@gnu.org> <4F6CADEF.4080700@yandex.ru> <87k422q8p7.fsf@fleche.redhat.com> In-Reply-To: <87k422q8p7.fsf@fleche.redhat.com> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg01069.txt.bz2 > You didn't say whether you regression-tested this. Yes, I didn't say it because I was not sure I have done it properly. I have run the gdb.mi tests but there were a few unexpected failures. However these failures are reproducible on gdb master branch without my changes, so it should be a problem with my environment setup. Unfortunately, I cannot figure out how to fix it. Moreover probably I should run all the tests (not only gdb.mi) with "make check" but I cannot found the overall statistics (only by every module), so it is quite hard to compare the results. I have read the Testsuite chapter[1] in gdb internals manual however that didn't help. Can you clarify me how the regression testing should be done or point me where to read about it? [1] http://sourceware.org/gdb/current/onlinedocs/gdbint/Testsuite.html#Testsuite > Anton> + if (real_type_found) > Anton> + *real_type_found = 0; Fixed > Too much indentation on the second line here. > > Anton> + if (real_type_found) > Anton> + *real_type_found = 1; > > Here too. Fixed > Anton> + if (real_type_found) > Anton> + *real_type_found = 1; > > Here too. Fixed > Anton> + REAL_TYPE_FOUND is used to inform whether the real type was found > Anton> + (or just static type was used). The NULL may be passed if it is not > Anton> + necessary. */ > > Two spaces after periods. > Just write "NULL", not "The NULL". Fixed. > Anton> + if (real_type_found) > Anton> + value = value_cast (var->type, value); > > Too much indentation. Fixed. > Anton> + int type_updated = update_type_if_necessary(existing, value); > > Space before open paren. Fixed. > Anton> + curr_type_str = varobj_get_type(var); > > Space before open paren. Fixed. > Anton> + if (update_type_if_necessary(v, new)) > Anton> + r.type_changed = 1; > > Too much indentation. Fixed. Anton.