From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22229 invoked by alias); 30 Mar 2012 15:59:51 -0000 Received: (qmail 22181 invoked by uid 22791); 30 Mar 2012 15:59:48 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 15:59:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2UFxPhr006971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Mar 2012 11:59:25 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2UFxMHL028470 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 30 Mar 2012 11:59:24 -0400 Message-ID: <4F75D859.1010907@redhat.com> Date: Fri, 30 Mar 2012 15:59:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA 1/2] Linespec rewrite (update 2) References: <4F70F8F7.503@redhat.com> <87zkb0wj1x.fsf@fleche.redhat.com> <4F74B583.6090008@redhat.com> <87obrertls.fsf@fleche.redhat.com> In-Reply-To: <87obrertls.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg01046.txt.bz2 On 03/30/2012 08:33 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> I don't know. The whole comma thing is undocumented. The test suite > Keith> does contain list ranges. That's how I originally discovered > Keith> this. I've removed the list mode restriction, though, and it doesn't > Keith> affect test results at all. > > You can write a test case using python that calls gdb.decode_line and > examines the remainder of the line. I'll see about writing a test that does this. > Comma-termination isn't documented but I think it has to be preserved > anyway. Already done. :-) > Keith> Yes, we can end up with a canonical form like "function:+5" or > Keith> "file:+5". The former is permitted (per recent maintainer request) > Keith> because we currently ignore the offset. [It is unprocessed in > Keith> convert_linespec_to_sals.] I'm not a fan of this, > > What is the rationale for having a linespec where parts are ignored? > I couldn't think of a use for it. And, if current cvs rejects it, then > it seems like it is interfering with a useful future feature as well. I agree, but perhaps I simply misunderstood Joel? http://sourceware.org/ml/gdb-patches/2012-03/msg00904.html Keith