From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89390-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 603 invoked by alias); 29 Mar 2012 18:50:25 -0000
Received: (qmail 592 invoked by uid 22791); 29 Mar 2012 18:50:24 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 18:50:12 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TIo2jU022199	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 29 Mar 2012 14:50:08 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2TIo0rP031439;	Thu, 29 Mar 2012 14:50:00 -0400
Message-ID: <4F74AED8.4020404@redhat.com>
Date: Thu, 29 Mar 2012 18:50:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,        Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: sparc gdbserver bug? (Re: [RFA] handle android bionic ptrace in gdbserver.)
References: <1332802002.30339.16.camel@hactar> <201203271611.q2RGBs2N025666@glazunov.sibelius.xs4all.nl> <1332894408.16415.14.camel@hactar> <4F749597.6000600@redhat.com> <CAMe9rOoyNjHZSRu_AUWbxB1NpY9S3mRZ__D3UceH=B2kdLSSdA@mail.gmail.com>
In-Reply-To: <CAMe9rOoyNjHZSRu_AUWbxB1NpY9S3mRZ__D3UceH=B2kdLSSdA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg01012.txt.bz2

On 03/29/2012 06:22 PM, H.J. Lu wrote:

> On Thu, Mar 29, 2012 at 10:02 AM, Pedro Alves <palves@redhat.com> wrote:


>>  #ifndef __sparc__
>>  -      res = ptrace (regset->get_request, pid, 0, buf);
>>  +      res = ptrace (regset->get_request, pid, nt_type, data);
>>  #else
>>  -      res = ptrace (regset->get_request, pid, buf, 0);
>>  +      res = ptrace (regset->get_request, pid, &iov, data);
>>  #endif
>>
>> I think that should have ended up with:
>>
>>  #ifndef __sparc__
>>       res = ptrace (regset->get_request, pid, nt_type, data);
>>  #else
>>       res = ptrace (regset->get_request, pid, data, nt_type);
>>  #endif
>>
> 
> It may be a typo for sparc branch.


Thanks.  I found a sparc-linux machine on the gcc compile farm,
and since I'm already making changes that affect all gdbserver
ports, I'll eventually run into it and fix it.

-- 
Pedro Alves