From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21414 invoked by alias); 29 Mar 2012 15:27:07 -0000 Received: (qmail 21398 invoked by uid 22791); 29 Mar 2012 15:27:05 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 15:26:50 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SDHFQ-0002VS-Ra from Hui_Zhu@mentor.com ; Thu, 29 Mar 2012 08:26:48 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 29 Mar 2012 08:26:48 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Thu, 29 Mar 2012 08:26:46 -0700 Message-ID: <4F747F34.8090208@mentor.com> Date: Thu, 29 Mar 2012 15:27:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] testsuite tfind.exp: If current target don't support trace, try gdbserver. References: <4F7428BD.30408@mentor.com> <4F742A2A.9060500@redhat.com> <4F742B75.3000408@mentor.com> <4F742F7D.1070602@redhat.com> <4F746B2A.6000302@mentor.com> <4F746DF3.5040500@redhat.com> <4F747005.8070109@mentor.com> <4F7470E7.7030001@redhat.com> <4F7473ED.6070007@mentor.com> <4F747435.1040805@redhat.com> <4F74750F.80006@mentor.com> <4F7478EB.7060709@redhat.com> In-Reply-To: <4F7478EB.7060709@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg01001.txt.bz2 On 03/29/12 22:59, Pedro Alves wrote: > On 03/29/2012 03:43 PM, Hui Zhu wrote: > >> That is back to the old question I ask for, right? :) >> >> Why the way try to make the trace function of GDB more easy be tested is not you want. > >> > >> And this way didn't affect current test. > > > We're going in circles. I already explained why. But let me try one last time. > We spawn the testsuite against a given target. It's wrong to run _some_ tests > against _yet another_ target if not that first one. The gdb.server/ tests are > special, and most scheduled for removal, exactly due to this issue. > > The trace function of GDB is not special compared to any other feature not > supported by the native debugger. If you spawn a test run to test the native > debugger, that's all that should be tested, with the features it doesn't support > skipped. If you spawn a test run to test the sim, that's all that should be > tested, with the features it doesn't support skipped. If you spawn a test run > to test a remote qemu, that's all that should be tested, with the features > it doesn't support skipped. If you spawn a test run to test a gdbserver, that's > all that should be tested, with the features it doesn't support skipped. > > People should already be testing routinely against both the native > target, and gdbserver. > > So the benefits of leaving the test run to test the target that it is meant > to test should be obvious. So, no, I'll strongly object to such patches. > > Another example, imagine if native debugging already supported tracing, but then > some patch inadvertently broke that, but then the test harness spawns gdbserver > when the native target says "sorry I can't to tracing", and the test runs > against gdbserver instead. You'd be masking the bug... > > If you want to make things easier, make it simpler to run the testsuite > against the just built gdbserver, without having to install the > native-gdbserver.exp (and friends) board files elsewhere, for example, with > a new makefile target ('make check-gdbserver' or some such), that points SITE > at an site.exp in the GDB source tree, that picks up the board > files under src/gdb/testsuite/boards. > OK. Thanks for your clear mail. I got it. Best, Hui