From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23200 invoked by alias); 29 Mar 2012 10:07:49 -0000 Received: (qmail 23190 invoked by uid 22791); 29 Mar 2012 10:07:48 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 10:07:22 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TA7IRD007236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Mar 2012 06:07:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2TA7HZt014198; Thu, 29 Mar 2012 06:07:17 -0400 Message-ID: <4F743454.4000502@redhat.com> Date: Thu, 29 Mar 2012 10:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: let find_gdbserver call which before return "" References: <4F73EE77.50907@mentor.com> <4F742E54.3040506@redhat.com> <4F743382.2020003@mentor.com> In-Reply-To: <4F743382.2020003@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00985.txt.bz2 Please don't top post. On 03/29/2012 11:03 AM, Hui Zhu wrote: > Hi Pedro, > > I agree with what you said. > > But my patch didn't affect what you want to test, because if ${GDB} is a built gdb binary, which will not return anything, find_gdbserver will keep return "". > > So only when ${GDB} is gdb, it will works. Sorry, I don't understand what you mean. -- Pedro Alves