From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29155 invoked by alias); 29 Mar 2012 01:17:32 -0000 Received: (qmail 29143 invoked by uid 22791); 29 Mar 2012 01:17:30 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_XP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 01:17:07 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SD3z6-0004aI-PB from Hui_Zhu@mentor.com ; Wed, 28 Mar 2012 18:17:04 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 28 Mar 2012 18:17:04 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 28 Mar 2012 18:17:03 -0700 Message-ID: <4F73B80C.7050703@mentor.com> Date: Thu, 29 Mar 2012 01:17:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0 MIME-Version: 1.0 To: Tom Tromey CC: , Pedro Alves Subject: Re: [PATCH]testsuite: test for disconnected-tracing References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> In-Reply-To: <87iphoy2xx.fsf@fleche.redhat.com> Content-Type: multipart/mixed; boundary="------------020201060801030508060305" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00969.txt.bz2 --------------020201060801030508060305 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 657 Hi Tom, Thanks for your review. I post a new patch according to your comments. Best, Hui 2012-03-29 Hui Zhu * gdb.trace/Makefile.in (BUILD_DATA_DIRECTORY): Add disconnected-tracing. * gdb.trace/disconnected-tracing.c: New file. * gdb.trace/disconnected-tracing.exp: New file. On 03/29/12 02:51, Tom Tromey wrote: >>>>>> ">" == Hui Zhu writes: > >>> +gdb_test "set confirm off" ".*" > > I think we use gdb_test_no_output for things like this now. > I'm not sure whether it applies to other cases in your patch. > >>> +gdb_test "delete" ".*" > > Perhaps just calling delete_breakpoints would work? > > Tom --------------020201060801030508060305 Content-Type: text/plain; charset="us-ascii"; name="disconnected-tracing.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="disconnected-tracing.txt" Content-length: 2781 --- testsuite/gdb.trace/Makefile.in | 2 testsuite/gdb.trace/disconnected-tracing.c | 5 ++ testsuite/gdb.trace/disconnected-tracing.exp | 59 +++++++++++++++++++++++++++ 3 files changed, 65 insertions(+), 1 deletion(-) --- a/testsuite/gdb.trace/Makefile.in +++ b/testsuite/gdb.trace/Makefile.in @@ -5,7 +5,7 @@ srcdir = @srcdir@ PROGS = ax backtrace deltrace infotrace packetlen passc-dyn passcount \ report save-trace tfile tfind tracecmd tsv unavailable while-dyn \ - while-stepping + while-stepping disconnected-tracing all info install-info dvi install uninstall installcheck check: @echo "Nothing to be done for $@..." --- /dev/null +++ b/testsuite/gdb.trace/disconnected-tracing.c @@ -0,0 +1,5 @@ +int +main() +{ + return 0; +} \ No newline at end of file --- /dev/null +++ b/testsuite/gdb.trace/disconnected-tracing.exp @@ -0,0 +1,59 @@ +# Copyright 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test of disconnected-tracing. + +load_lib "trace-support.exp"; + +set testfile "disconnected-tracing" +set executable $testfile +set srcfile ${testfile}.c +set binfile $objdir/$subdir/$testfile +set expfile $testfile.exp +set gdbserver_reconnect_p 1 + +if [prepare_for_testing $expfile $executable $srcfile \ + {debug nowarnings}] { + untested "failed to prepare for trace tests" + return -1 +} + +if ![runto_main] { + fail "Can't run to main to check for trace support" + return -1 +} + +if ![gdb_target_supports_trace] { + unsupported "target does not support trace" + return -1; +} + +gdb_test_no_output "set confirm off" ".*" + +gdb_test "trace main" ".*" +gdb_test "tstart" ".*" + +gdb_test "info tracepoints" ".*in main at.*" "First info tracepoints" +gdb_test "disconnect" ".*" + +gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport +gdb_test "info tracepoints" ".*in main at.*" "Second info tracepoints" +gdb_test "disconnect" ".*" + +delete_breakpoints +gdb_test "info tracepoints" ".*No tracepoints..*" "Third info tracepoints" + +gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport +gdb_test "info tracepoints" ".*in main at.*" "Fourth info tracepoints" --------------020201060801030508060305--