From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27841 invoked by alias); 27 Mar 2012 01:45:16 -0000 Received: (qmail 27829 invoked by uid 22791); 27 Mar 2012 01:45:15 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Mar 2012 01:45:01 +0000 Received: by pbcup15 with SMTP id up15so7251349pbc.0 for ; Mon, 26 Mar 2012 18:45:01 -0700 (PDT) Received: by 10.68.194.103 with SMTP id hv7mr36406198pbc.133.1332812701369; Mon, 26 Mar 2012 18:45:01 -0700 (PDT) Received: from [193.168.1.100] ([125.118.48.150]) by mx.google.com with ESMTPS id j10sm7187029pbf.0.2012.03.26.18.44.57 (version=SSLv3 cipher=OTHER); Mon, 26 Mar 2012 18:45:00 -0700 (PDT) Message-ID: <4F711BCB.7070905@gmail.com> Date: Tue, 27 Mar 2012 01:45:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA 1/2] Linespec rewrite (update 2) References: <4F70F8F7.503@redhat.com> In-Reply-To: <4F70F8F7.503@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00899.txt.bz2 Hi, Keith. Thanks for the improvement. I'm testing your line spec rewrite branch, it works great. When I review the log in gdb CVS HEAD: http://sourceware.org/ml/gdb-patches/2012-03/msg00819.html [debug]> break "E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64" [debug]No source file named E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp. [debug]Breakpoint 2 ("E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64) pending. See the third line, the response from GDB does not have quote balanced. I mean, the tail quote is lost. So, to catch such string, we have currently use the regular expression in Code::blocks' source code: static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\(\\\"(.+):([0-9]+)\\)[ \t]pending\\.")); Now, I'm using your branch, and the result is: [debug]> break "E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29" [debug]No source file named E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp. [debug]Breakpoint 4 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29") pending. You can see, the third line, it does have a tail quote. I believe adding the tail quote is the right direction. Also, I can easily adjust the regex to: static wxRegEx rePendingBreakpoint(_T("Breakpoint ([0-9]+)[ \t]\\(\\\"(.+):([0-9]+)\\\"\\)[ \t]pending\\.")); Yuanhui Zhang Code::blocks developer