From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6482 invoked by alias); 26 Mar 2012 20:35:24 -0000 Received: (qmail 6396 invoked by uid 22791); 26 Mar 2012 20:35:23 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 20:35:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2QKZ2pE001755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Mar 2012 16:35:03 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2QKYwjV031981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 26 Mar 2012 16:35:01 -0400 Message-ID: <4F70D2F2.1090604@redhat.com> Date: Mon, 26 Mar 2012 20:35:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA 3/3] Linespec rewrite: New tests References: <4F67A3B3.6030500@redhat.com> <87mx73s4om.fsf@fleche.redhat.com> In-Reply-To: <87mx73s4om.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00890.txt.bz2 On 03/26/2012 09:33 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > If these tests all pass against CVS gdb, I think this could go in > independently of the rewrite patch. ls-dollar.exp does pass today, so if you would like, I can commit that separately (now). Obviously, ls-errs.exp will not pass (as-is) because of the error message changes. I don't see any value in adapting this test to pass CVS HEAD. > Keith> +set base "ls-dollar" > Keith> +set srcfile "$base.cc" > Keith> +set testfile "$base.exp" > Keith> +set exefile $base > Keith> + > Keith> +if {[skip_cplus_tests]} { > Keith> + unsupported linespec.exp > > Wrong text in the argument here. > I think the new trend, proposed in the not-too-distant past by Pedro > (IIRC), is to put some useful text in there instead of just the .exp > name, since that is redundant anyhow. Whoops. I've updated that. > Keith> +set base ls-errs > Keith> +set srcfile "$base.c" > Keith> +set testfile "$base.exp" > Keith> +set exefile $base > Keith> + > Keith> +if {[skip_cplus_tests]} { > Keith> + unsupported linespec.exp > > Wrong text -- but there doesn't seem to be a need to examine > skip_cplus_tests here at all. Yeah, another cut-n-paste casualty. I've removed that and pushed both fixes to the archer branch. Keith