From: Pedro Alves <palves@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org, libc-alpha@sourceware.org,
drepper@gmail.com,
"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: struct siginfo vs. siginfo_t
Date: Wed, 21 Mar 2012 12:21:00 -0000 [thread overview]
Message-ID: <4F69C79C.7090606@redhat.com> (raw)
In-Reply-To: <87limuf9zn.fsf@schwinge.name>
Okay, but,
On 03/21/2012 11:51 AM, Thomas Schwinge wrote:>
> gdb/
> * amd64-linux-nat.c (amd64_linux_siginfo_fixup): Use siginfo_t instead
> of struct siginfo.gdb_siginfo_t.
'gdb_siginfo_t.' here looks like a pasto.
> * arm-linux-nat.c (arm_linux_stopped_data_address): Likewise.
> * ia64-linux-nat.c (ia64_linux_stopped_data_address): Likewise.
> * linux-nat.c (linux_nat_siginfo_fixup, siginfo_fixup)
> (linux_xfer_siginfo, linux_nat_set_siginfo_fixup)
> (linux_nat_get_siginfo): Likewise.
> * linux-nat.h (lwp_info, linux_nat_set_siginfo_fixup)
s/lwp_info/struct lwp_info/
> (linux_nat_get_siginfo): Likewise.
> * linux-tdep.c (linux_get_siginfo_type): Likewise.
> * ppc-linux-nat.c (ppc_linux_stopped_data_address): Likewise.
> * procfs.c (gdb_siginfo_t): Likewise.
>
> gdb/gdbserver/
> * linux-arm-low.c (arm_stopped_by_watchpoint): Use siginfo_t instead of
> struct siginfo.gdb_siginfo_t.
'gdb_siginfo_t.' here looks like a pasto.
> * linux-low.c (siginfo_fixup, linux_xfer_siginfo): Likewise.
> * linux-x86-low.c (x86_siginfo_fixup): Likewise.
> * linux-low.h (linux_target_ops): Likewise. Include <signal.h> instead
> of declaring struct siginfo as incomplete type.
* linux-low.h: Include <signal.h>.
(struct siginfo): Delete forward declaration.
(struct linux_target_ops) <siginfo_fixup>: Use siginfo_t instead of
struct siginfo.
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2012-03-21 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120226181752.1175.qmail@sourceware.org>
[not found] ` <87zkbhkipp.fsf@schwinge.name>
[not found] ` <CADZpyiwXDJSPRDoQpA3ZOTYsznMc_2DrVpr3z0y-zt2z5FjkRQ@mail.gmail.com>
2012-03-21 11:51 ` Thomas Schwinge
2012-03-21 12:21 ` Pedro Alves [this message]
2012-03-21 13:45 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69C79C.7090606@redhat.com \
--to=palves@redhat.com \
--cc=carlos@systemhalted.org \
--cc=drepper@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=libc-alpha@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox