From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8569 invoked by alias); 17 Mar 2012 01:13:04 -0000 Received: (qmail 8555 invoked by uid 22791); 17 Mar 2012 01:13:03 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_SM X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Mar 2012 01:12:50 +0000 Received: by iajr24 with SMTP id r24so7337887iaj.0 for ; Fri, 16 Mar 2012 18:12:50 -0700 (PDT) Received: by 10.50.51.169 with SMTP id l9mr985558igo.4.1331946770287; Fri, 16 Mar 2012 18:12:50 -0700 (PDT) Received: from [192.168.1.128] ([60.186.236.215]) by mx.google.com with ESMTPS id ko6sm858055igc.2.2012.03.16.18.12.47 (version=SSLv3 cipher=OTHER); Fri, 16 Mar 2012 18:12:49 -0700 (PDT) Message-ID: <4F63E535.7060904@gmail.com> Date: Sat, 17 Mar 2012 01:13:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [windows] patch to set breakpoint in a dll References: <4F54D758.8020508@gmail.com> <4F5816EE.4050908@gmail.com> <20120314182606.F20822461B2@ruffy.mtv.corp.google.com> <4F629CE5.8030301@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00646.txt.bz2 On 2012-3-17 6:23, Doug Evans wrote: > On Thu, Mar 15, 2012 at 6:52 PM, asmwarrior wrote: >> > Ok, this is the new patch.(I have problem using the TortoiseGit to generate >> > a diff between two revisions.you can see, the file name is long and dirty) >> > >> > >> > Also, the log message is what you wrote: >> > >> > >> > 2012-03-14 Zhang Yuanhui >> > >> > * source.c (find_and_open_source): Consistently pass resulting >> > full path through xfullpath. >> > >> > >> > My family name is "Zhang", so I'm not sure it should be put before the given >> > name or after the given name. The Chinese name and English name have >> > different formats. > I say it's your choice. I just copied from an existing example in ChangeLog. OK, please use the conversion Yuanhui Zhang which is similar to some gdb developers like: Hui Zhu and Yao Qi. > Heh. One last nit. Blank line between these two lines. > > + char *lpath; > + lpath = xfullpath (*fullname); > > [or combine them, but then you still need a blank line afterwards] > > Can you check the patch in? I'm happy to for you if necessary (at > which point I can just insert the blank line before checkin). Thanks, I have no cvs write access, so please help me to check in by fixing the tiny nit. Yuanhui Zhang PS: resend the email to gdb patches maillist by using the plain text format.