From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1203 invoked by alias); 16 Mar 2012 15:57:55 -0000 Received: (qmail 1193 invoked by uid 22791); 16 Mar 2012 15:57:54 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Mar 2012 15:57:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2GFvcvU020597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Mar 2012 11:57:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2GFvabK004557; Fri, 16 Mar 2012 11:57:37 -0400 Message-ID: <4F6362F0.2050906@redhat.com> Date: Fri, 16 Mar 2012 15:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Mark Kettenis CC: yao@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Use sized types in tracepoint. References: <1331905618-2631-1-git-send-email-yao@codesourcery.com> <201203161550.q2GFoQhS029855@glazunov.sibelius.xs4all.nl> In-Reply-To: <201203161550.q2GFoQhS029855@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00621.txt.bz2 On 03/16/2012 03:50 PM, Mark Kettenis wrote: > We have gnulib/stdint.h so using typedefs like int32_t should be ok. GDBserver doesn't use gnulib, unfortunately. Thought, it looks like the Linux, Windows and Lynx backends already unconditionally include stdint.h. The NTO backend doesn't, so I'm not sure if we can include it unconditionally. On 03/16/2012 01:46 PM, Yao Qi wrote: > +#include > #if HAVE_STDINT_H ^^^^^^^^^^^^^ > #include > #endif So I'd like to see that HAVE_STDINT_H removed first. If this causes trouble, the option would be for gdbserver to use gnulib proper. -- Pedro Alves