From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11136 invoked by alias); 14 Mar 2012 23:54:54 -0000 Received: (qmail 11128 invoked by uid 22791); 14 Mar 2012 23:54:53 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-dupuy.atl.sa.earthlink.net (HELO elasmtp-dupuy.atl.sa.earthlink.net) (209.86.89.62) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Mar 2012 23:54:40 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-dupuy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1S7y1f-00065s-Cn for gdb-patches@sourceware.org; Wed, 14 Mar 2012 19:54:39 -0400 Message-ID: <4F612FBE.10405@earthlink.net> Date: Wed, 14 Mar 2012 23:54:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit References: <4F610188.5010001@onevision.com> <20120314210310.GJ2853@adacore.com> In-Reply-To: <20120314210310.GJ2853@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940114c2343da3c42c6bea77c66759bdd0f350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00519.txt.bz2 On 3/14/12 2:03 PM, Joel Brobecker wrote: >> There is a script called gdb_indent.sh in gdb's root dir. I applied >> it on amd64-windows-nat.c ahead of getting out my patch thinking >> that this would be the correct way. Some misunderstanding as it >> produced most of your indention concerns. > That is very odd, the script should indeed indent the sources > in a way that follows the GNU Coding Standards. Perhaps we are > missing some parameters in the call to that script that override > certain defaults that may no longer match our standards. But FWIW, > we have rarely used that script in the past few years. I think > that this is because GNU indent, the tool that it uses underneath, > isn't very smart and often produces a layout that's worse than > what a human would produce. > I've never been able to get indent to produce exactly the same results as Emacs' indent, even though in theory they are using the same algorithm with the same parameters. Probably the best recommendation for contributors is to use Emacs indent-region on their new code fragments, and to leave everything else in the file alone. Stan