Re: Fwd: Re: [patch] Add support for ARMv7M devices.

Jonathan Larmour
2012-03-09T15:53:02Z

On 09/03/12 11:44, Pedro Alves wrote:
> On 03/09/2012 04:24 AM, Jonathan Larmour wrote:
> I support this. I wrote essentially the same without being aware of
> your patch: <http://sourceware.org/ml/gdb-patches/2011-04/msg00372.html>.
>
> Wish I had seen yours before that.
>
> If there are no other comments in a week or so, I say put this in.

I have noticed one slight practical difference with your patch... Mine used:
+ <xi:include href="arm-fpa.xml"/>

whereas yours enumerates all the FPA registers, but with the name set to
"", which is better - I hadn't been aware of that property of not showing
a reg if the name is empty.

> On 03/09/2012 04:24 AM, Jonathan Larmour wrote:
>> }
>> + else
>> + is_m = 0;
>>
>
> I think this is unnecessary though. The variable is initialized to 0.

True. I thought I needed to reset it if it got set further up, but now I
see that couldn't happen ( because !tdesc_has_registers in that case)

So perhaps should we just go with your version of the patch after all?
It's effectively identical other than the above FPA name improvement.

Jifl
--
eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
** Visit us at the ESC Expo at Design West in San Jose **
** 27-29 March, McEnery Convention Center - Stand #846 **
------["Si fractum non sit, noli id reficere"]------ Opinions==mine