From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29890 invoked by alias); 9 Mar 2012 15:53:02 -0000 Received: (qmail 29877 invoked by uid 22791); 9 Mar 2012 15:53:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 15:52:46 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 58EB82F78006; Fri, 9 Mar 2012 15:52:45 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3KQMoug+j40P; Fri, 9 Mar 2012 15:52:40 +0000 (GMT) Message-ID: <4F5A2747.8070809@eCosCentric.com> Date: Fri, 09 Mar 2012 15:53:00 -0000 From: Jonathan Larmour User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: Fwd: Re: [patch] Add support for ARMv7M devices. References: <4F598611.4020506@eCosCentric.com> <4F59ED15.1030109@redhat.com> In-Reply-To: <4F59ED15.1030109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00334.txt.bz2 On 09/03/12 11:44, Pedro Alves wrote: > On 03/09/2012 04:24 AM, Jonathan Larmour wrote: > I support this. I wrote essentially the same without being aware of > your patch: . > > Wish I had seen yours before that. > > If there are no other comments in a week or so, I say put this in. I have noticed one slight practical difference with your patch... Mine used: + whereas yours enumerates all the FPA registers, but with the name set to "", which is better - I hadn't been aware of that property of not showing a reg if the name is empty. > On 03/09/2012 04:24 AM, Jonathan Larmour wrote: >> } >> + else >> + is_m = 0; >> > > I think this is unnecessary though. The variable is initialized to 0. True. I thought I needed to reset it if it got set further up, but now I see that couldn't happen ( because !tdesc_has_registers in that case) So perhaps should we just go with your version of the patch after all? It's effectively identical other than the above FPA name improvement. Jifl -- eCosCentric Limited http://www.eCosCentric.com/ The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071. ** Visit us at the ESC Expo at Design West in San Jose ** ** 27-29 March, McEnery Convention Center - Stand #846 ** ------["Si fractum non sit, noli id reficere"]------ Opinions==mine