Re: Fwd: Re: [patch] Add support for ARMv7M devices.

Pedro Alves
2012-03-09T16:06:06Z

On 03/09/2012 03:52 PM, Jonathan Larmour wrote:

> On 09/03/12 11:44, Pedro Alves wrote:
>> On 03/09/2012 04:24 AM, Jonathan Larmour wrote:
>> I support this. I wrote essentially the same without being aware of
>> your patch: <http://sourceware.org/ml/gdb-patches/2011-04/msg00372.html>.
>>
>> Wish I had seen yours before that.
>>
>> If there are no other comments in a week or so, I say put this in.
>
> I have noticed one slight practical difference with your patch... Mine used:
> + <xi:include href="arm-fpa.xml"/>
>
> whereas yours enumerates all the FPA registers, but with the name set to
> "", which is better - I hadn't been aware of that property of not showing
> a reg if the name is empty.

Ah, yes.

>
>> On 03/09/2012 04:24 AM, Jonathan Larmour wrote:
>>> }
>>> + else
>>> + is_m = 0;
>>>
>>
>> I think this is unnecessary though. The variable is initialized to 0.
>
> True. I thought I needed to reset it if it got set further up, but now I
> see that couldn't happen ( because !tdesc_has_registers in that case)
>
> So perhaps should we just go with your version of the patch after all?
> It's effectively identical other than the above FPA name improvement.

I suppose so. Your patch predates mine, so it'll be fair to put your name
in the ChangeLog, like:

2012-03-09 Jonathan Larmour <jifl@eCosCentric.com>
Pedro Alves <pedro@codesourcery.com>

Can you do that and repost the final patch? Feel free to adjust comments and
such if you prefer. Then if there are no further comments, we can check it in.

--
Pedro Alves